Yuecheng Wu
848cc7d3de
Adding more tests for fs.copyFile
...
Co-authored-by: David Humphrey <david.humphrey@senecacollege.ca>
2018-12-17 16:18:06 -05:00
David Humphrey
ba188169d6
Review fixes, skip copyFile test for now
2018-12-17 16:06:24 -05:00
mordax
62cbe11a93
Fixed lint issues in copyFile test
2018-12-17 15:56:55 -05:00
mordax
ef80713c33
Added tests for future fs.copyFile implementation and adjusted index.js to run it.
2018-12-17 15:56:55 -05:00
Alexei Kozachenko
0eb7066a86
Added mkdtemp method (issue #441 )
...
Added/fixed mkdtemp method (issue 441)
Added/fixed mkdtemp method (issue 441)
Added/fixed mkdtemp method (issue 441)
fixed a typo
Added mkdtemp method description to readme
Unit tests for mkdtemp method added (issue #394 )
Added generateRandom(), randomChars() to shared.js. Corrections in README. Fixes for mkdtemp method
cleaned up mkdtemp()
fixed regex
Fix for failing test (humphd)
2018-12-15 00:39:09 -05:00
David Humphrey
158f6241b6
Fixes from #504 to pass lint, travis
2018-12-15 00:17:43 -05:00
Dan Lin
4a5d8c1222
Fix #456 - add test for fs.write() with undefined path
2018-12-15 00:14:13 -05:00
kwkofler
443b582038
Issue #86 : Added support for Unix Timestamps
...
Co-authored-by: David Humphrey <david.humphrey@senecacollege.ca>
2018-12-14 23:58:42 -05:00
David Humphrey
83bd64fd58
Fix lint issues in #521
2018-12-14 22:18:25 -05:00
imedqq
783e7a9e67
Added newline at end of file
2018-12-14 22:18:25 -05:00
imedqq
2aa6cf2b5f
Added promise-based test cases for rmdir
2018-12-14 22:18:25 -05:00
David Humphrey
acef2c93b0
Update https://github.com/filerjs/filer/pull/485 to master, add tests + fix.
2018-12-14 22:05:51 -05:00
Deepanjali Gerangal
94fd5ba829
Fix#418-updated method
2018-12-14 19:24:55 -05:00
Deepanjali Gerangal
e3a285ae54
fix #418 test for fsPromises.truncate(path[, len]) to test when length is negative
2018-12-14 19:24:19 -05:00
Petr Bouianov
1775c24d37
Fixes issue 75
...
As the array flags were already reflected in the README documentation
and example, this only required a test
2018-12-14 17:31:31 -05:00
David Humphrey
2841b2eba7
Fixes from review
2018-12-12 22:09:41 -05:00
Mera-Gangapersaud
0352dad66c
Corrected Travis CI error for issue 500
2018-12-12 22:09:41 -05:00
David Humphrey
33339b81d7
Fix review issues
2018-12-12 21:38:16 -05:00
Adam
7e941bb304
Update fs.symlink.spec.js
2018-12-12 21:38:16 -05:00
Adam
db237e617b
update fs.symlink.spec.js based on code review
...
white spaces , comments added, Promises.Open used
2018-12-12 21:38:16 -05:00
Pooch11
0a1aa0fecc
Added tests for symlink using promises api
2018-12-12 21:38:16 -05:00
David Humphrey
16e6b3e1c9
Fix review issues
2018-12-12 21:31:27 -05:00
Dragomegak
af3815c54b
Removes Symbolic Link check & Fixing Mixing Callbacks and Promises (Basically the fs.link test though)
2018-12-12 21:27:13 -05:00
Dragomegak
0748951ca8
Changed code to reflect promise syntax
2018-12-12 21:27:13 -05:00
Dragomegak
265f0b1d0d
Added fsPromises.link() tests
2018-12-12 21:27:13 -05:00
David Humphrey
1c450ae8e7
Fix review nits, move contents to earlier scope and reuse.
2018-12-12 21:08:30 -05:00
PopeSpaceous
0395c4beae
Fix issue-447: Added test to append numbers in fs.appendFile function
2018-12-12 21:08:30 -05:00
jagmeetb
1abcb0369b
Fix #431 : add test for fsPromises.unlink
...
add newline at end
implemented suggestions
formatting fixes
2018-12-12 20:59:41 -05:00
David Humphrey
d1dd5fef61
Finishing work in #401
2018-12-10 23:57:10 -05:00
Josh Mayers
e85880dc8b
Fix Issue #399 - added test cases for appendFile with promises
2018-12-10 23:57:10 -05:00
David Humphrey
5218057d80
Follow-up from #603 , rename ImportExportProvider to SerializableMemoryProvider
2018-12-05 10:18:31 -05:00
David Humphrey
61a1f5e020
Fix #603 : add import/export provider to work with JSON fs images
2018-12-04 22:54:29 -05:00
Deepanjali Gerangal
0f93a04e40
Fix for issue #561 - Extend fs.access to support R_OK, W_OK, and X_OK ( #601 )
...
* added extended test for fs.access
* making requested changes
2018-12-03 23:08:40 -05:00
David Humphrey (:humph) david.humphrey@senecacollege.ca
f5678ebe20
Rebase and rework test, skip() for now, see #594
2018-12-02 10:19:43 -05:00
kwkofler
97fb82769a
Issue #158 - Added test to ensure that watchers monitoring hardlinks are notified when the original file is updated
2018-12-02 10:19:43 -05:00
David Humphrey (:humph) david.humphrey@senecacollege.ca
7d196763f8
Update docs, fix test failure
2018-12-02 00:05:57 -05:00
kwkofler
6a5d9073f3
Issue 87 - Added fs.fsync() as a no-op, and added tests. Modified documentation.
...
Made requested changes to tests, functionality; reverted doc changes
2018-12-02 00:05:57 -05:00
David Humphrey (:humph) david.humphrey@senecacollege.ca
a107fe21d7
Fix #337 : Pick up sedge's changes from 3c49743559
2018-12-01 22:20:09 -05:00
David Humphrey (:humph) david.humphrey@senecacollege.ca
d7945d745d
Fix #577 : deal with promise exceptions and test console spam
2018-12-01 22:07:24 -05:00
David Humphrey (:humph) david.humphrey@senecacollege.ca
923b999e89
Fix #547 : update Buffer use, docs, tests to match node.js v11.3.0
2018-12-01 20:05:05 -05:00
David Humphrey (:humph) david.humphrey@senecacollege.ca
cc6e3f7edf
Increase coverage: check for non-int with chown/fchown
2018-11-29 22:47:26 -05:00
David Humphrey
43d2632069
Improve coverage: add test for rel paths with symlink
2018-11-29 16:57:06 -05:00
yatsenko-julia
f57c7330d3
fix #556 : added tests for fs.ftruncate method ( #557 )
...
* fix #556 : added tests for fs.ftruncate method
* Update fs.ftruncate.spec.js
2018-11-28 22:42:17 -05:00
David Humphrey
d1cf1286cb
Fix #576 : remove unnecessary methods from fs.promises, adjust tests to match
2018-11-28 19:42:32 -05:00
David Humphrey
2135ee17e9
Update fs.stat.spec.js to not have uncaught exception on promise
2018-11-28 19:41:46 -05:00
David Humphrey
725bfbf30c
Fixes #422 : Add nyc lcov-based code coverage for tests ( #565 )
...
* Add nyc lcov-based code coverage for tests
* Add codecov to travis
* Add codecov badge to README
2018-11-28 19:24:03 -05:00
yuzhouChen
89626107cc
Fix #568 : switch all stats.type checks in tests/ to use is*() methods ( #581 )
...
* Fix Issue#568
* Fix issue 568: two more file changes
* Fix issue 568: more changes in tests/spec/shell/ls.spec.js
2018-11-28 13:54:20 -05:00
Susan Truong
a25d71b524
Fix #435 : add a test for fsPromise.unlink() to delete a file that does not exist
...
Make changes to `fsPromises.unlink()` to be more promise-friendly
Added a newline to the end of the file
Made a change to fsPromises.unlink() to be more friendly
Changed the description of the promises test
2018-11-27 13:18:39 -05:00
Alan K
d1afe9719d
Merge pull request #476 from steaward/issue-420
...
Fixes #420
2018-11-22 01:46:52 -05:00
Deepanjali Gerangal
400b2c3c88
Fix #558 - Implementing fs.access() method ( #560 )
...
* Implementing fs.access() method
* added new line to access.js
* updated requested changes
* updated README.md with fs.access
* fixing truncate error
* updated README.md
* changed access.js to access.spec.js
2018-11-17 15:31:20 -05:00
Alexander Ponomaroff
ce030b91fa
Fix issue #398 - Add testing for promises to all test cases in fs.writeFile-readFile.spec.js file ( #402 )
...
* Fix issue #398 - Add testing for promises to all test cases in fs.writeFile-readFile.spec.js file
* Fix issue #398 - Add testing for promises to all test cases in fs.writeFile-readFile.spec.js file
* Fixed requested issues
* Further Improvement
2018-10-20 16:59:26 -04:00
Deepanjali Gerangal
5568c27bec
fix for #542 for fsPromises.symlink(target, path[, type]) ( #543 )
...
* updating fs.symlink for promises
* updated the requested changes
* fix#542 added a newline at end
2018-10-20 16:57:45 -04:00
Volodymyr Klymenko
bfcb5a6a94
Added tests for Promises version of mkdir ( #415 )
2018-10-16 19:27:12 -04:00
ThomasNolte
3bbabfcb4a
added tests for fs.promises.chown() closes #465 ( #471 )
...
* added tests for fs.promises.chown() for check if function exists and updating gid/uid for a file
* update to pass lint tests
* cleaned up code. replaced all callbacks with promises in new test.
* Revert "lint tests fix"
This reverts commit 3c256124cf
, reversing
changes made to 71a6f514fc
.
* Revert "cleaned up code. replaced all callbacks with promises in new test."
This reverts commit 71a6f514fc
.
* Made requested changes.
2018-10-16 11:43:59 -04:00
Shawn Pang
1eab5f0ffd
Fix#461 - Added test for fs.read when attempting to read a file that does not exist ( #472 )
...
* Added test for fs.read when attempting to read a file that does not exist
* Added test for fs.read when attempting to read a file that does not exist
* Modified read test for non-existent file to act more similar to earlier tests
* Added check in read test for error code
2018-10-16 11:22:54 -04:00
yatsenko-julia
73f0f19bb9
Fix #523 : added tests for fs.ftruncate() ( #524 )
...
* Fix #523 : added tests for fs.ftruncate()
* fix #523 : moved a function from truncate to ftruncate and made a few minor changes
* Fixed indentation
2018-10-16 11:21:49 -04:00
bblarney
707d404db0
Issue 417 - Added test for fs.promises.rename to rename existing directory ( #460 )
...
* test added
* working so far
* done
* cleaned up a catch
* made some requested changes
2018-10-16 11:07:10 -04:00
VictorKubrak
a447b2dd45
rename() should be able to rename an existing file to the same filename ( #502 )
...
* rename should not change name to itself
* new test expects failure
* should rename an existing file to itself
* should rename an existing file to itself
* Update tests/spec/fs.rename.spec.js
* add .skip to the test
2018-10-16 09:43:44 -04:00
AHKol
8aa8dda4d6
Fix #411 : Tests if event is thrown when calling rename ( #478 )
...
* Fix #411 : Tests if event is thrown when calling rename
* npm run lint:fix
* Added comment explaining lack of 'rename' event check
2018-10-15 16:33:47 -04:00
Stephen Ward
675773b92a
re-added the newline, as well as another test case to make sure mode is still set to default value when a new file is opened
2018-10-10 15:10:34 -04:00
Janice
41510e7da4
Fix issue 529 ( #530 )
...
* Fix issue 529
* Fix Issue 529
* Fix issue 529 and some indentations
* fix arrow function instead of function expression
* Fix issue529
* Fix issue529
* Saving files before refreshing line endings
* done
* push again
* change sth
* changed
2018-10-09 21:17:25 -04:00
Stephen Ward
7a6a4160e6
made changes as per thomas's and dave's PR review
2018-10-09 20:25:19 -04:00
pynnl
c33f22b464
Issue 396 - Add a test for fs.promises.stat() when the path does not exist ( #406 )
...
* test non exist path for promise
* fix new line at the end
* fix missing semicolon 113:26
* follow 'Testing promise codes' on guidline
2018-10-09 17:40:35 -04:00
Julia McGeoghan
389dedd3c0
Fix #421 - Add test for fs.promises.link to ensure it returns a Promise ( #462 )
...
* Add test
* Move location of describe block
* Remove comment
* Have test check returnValue and not obj
* Override package-lock.json with one from master branch
* Improve naming of fsPromise variable to be more clear
2018-10-09 17:35:28 -04:00
yuzhouChen
8504cc7e2a
Issue497 Add test for fs.chmod when the path is invalid ( #525 )
...
* Fix #497 Add test for fs.chmod when the path is invalid
* Fix #497 All test passed
2018-10-09 17:30:36 -04:00
yevseytsev
27659d45da
491 ( #501 )
...
* mkdir - restricted symbols('?' only)
* FINAL
2018-10-09 17:28:14 -04:00
Stephen Truong
934ef8bfa7
Fix #419 : Add test for fsPromises.open() when the path does not exist ( #455 )
...
* Fix #419 : Add test for fsPromises.open() when the path does not exist
* Update package.json
* Fix #419 : Add test for fsPromises.open() when the path does not exist
Removed some unnecessary code based on reviews
* Update fs.open.spec.js
2018-10-09 16:00:56 -04:00
Ruihui Yan
c7ea45a18b
Fix issue #475 - Add test for fs.exits() when resulting path of a symbolic link is not found ( #519 )
...
* add test for exits when resulting path of a symbolic link is not found
* fixed style nit
2018-10-09 14:31:15 -04:00
Sean
009821290f
Fixes #499 : Update functionality for fs.truncate ( #533 )
...
* Fixes #499 : Update functionality for fs.truncate
This change to fs.truncate()'s functionality throws an error when the
length to truncate by is a non-numeric string.
* Refactor numeric type validation
As node implements a helper function to validate numeric values, let's
replicate the same logic to use throughout Filer.
2018-10-09 13:53:26 -04:00
Thanh Nguyen
2f3c384868
Add test for fsPromises.rmdir() when dir not empty and dir is a file, Fix Issue 474 ( #510 )
...
* Saving files before refreshing line endings
* Adding test case for returning an error if the path is not a directory
* Add return for fsPromises, and few other small fixes
* Fix promises, and few done parameter
* Update fs.rmdir.spec.js
2018-10-09 13:51:19 -04:00
giantpanpan
beea03dbae
Add test for fs.writeFile-readFile.spec to write a file in non-existing path ( #486 )
2018-10-09 13:48:51 -04:00
ywpark1
3e0da99040
Fix issue-426: Add the test for fsPromises.readdir when the path exists, and is a directory ( #452 )
2018-10-09 13:32:09 -04:00
dleung25
02bd6d8a62
Issue#518 fix: Add test for fsPromises.unlink() should be a function ( #526 )
...
* issue518 fix
* changed back to original package.json
* add newline to end of file
2018-10-09 13:27:22 -04:00
Jeffrey Espiritu
7e27c8be2c
Fix Issue #400 - add test for passing file to fs.promise.readdir() ( #409 )
...
* Fix Issue #400 - add test for passing file to fs.promise.readdir()
This adds a test to ensure that `fs.promise.readdir()` throws an error when passing in a file.
* Made changes to `fsPromises.readdir` to be more promise-friendly
2018-10-09 13:04:19 -04:00
Casva
e77361107e
Issue 427 - Add tests to fsPromises.rmdir when directory doesn't exist and when trying to delete root directory ( #457 )
...
* Fix #427 - Fixed indentation and ENOENT -> EBUSY on line 120
* Deleted extra line at the end of document
* Fix #427 - Added tests for fsPromises.rmdir when trying to remove a nonexistent directory and when trying to remove root directory
2018-10-09 13:02:01 -04:00
Daniel Bogomazov
87230ce1e3
Fix #405 - Added tests for chmod and fchmod using Promises ( #458 )
...
* Added tests for chmod and fchmod using Promises
* Remove unrelated files from pull request
* Fixed spelling mistake
* Removed redundant catch blocks
2018-10-09 12:59:17 -04:00
Huda Al Dallal
2e2e2f9d64
Fixed issue#480 using promises to test fs.truncate when path does not exist ( #516 )
...
* added a test for issue#480 using promises to test fs.truncate
* Fixed issue#480 tesing fs.truncate using promises when path does not exist
2018-10-09 12:56:20 -04:00
rdittrich97
0354c7e13e
Fix #423 : added proimse support for fs.stat ( #432 )
...
* added promise support to fs.stat
* restored package lock
* fixed lint issues
* made tests more promise freindly
* removed .catch statement from promise and fixed style issues
* removed .catch statement from promise and fixed style issues
2018-10-09 12:54:40 -04:00
y2s82
1156f420c4
Fixed #424 - implement fs.promises.read tests ( #429 )
...
* implemented first two tests of fs.promises.read
* simplified the 2nd fs.promises.read test
* implemented test on file position update for fs.promises.read
* implemented directory read failure test for fs.promises.read
* implemented test to check the return type to be a Promise in fs.promises.read
* fixed indentation and also fixed a catch statement to allow all code to be reachable
* made tests more promise-friendly
* applied some style changes and test changes as per @rdittrich97 suggestions
* removed lines that are unnecessary for promise-based testing and syntactically simplified some function definitions
* removed more unnecessary check lines in directory check fail test
2018-10-09 12:51:59 -04:00
Nick Skuybeda
86b6b2a907
Fixed Issue #483 for a test done for fs.mknod promise ( #509 )
...
* test done for fs.mknod promise
* fixing whitespaces
2018-10-09 12:43:45 -04:00
Chaya Danzinger
a8759b1e38
Add tests for fs.promises utimes function #527 ( #540 )
...
* first two promise tests initial commit
* implemented existing tests but with promises
* add final tests
* add return statement for remaining tests
* fix function call error
2018-10-09 12:39:18 -04:00
rhayes2
7a716e033b
Add chmod --test for chmode mode value
2018-09-25 00:31:49 -04:00
rhayes2
395de63751
aDD Chmod --test for chmod
2018-09-25 00:29:33 -04:00
rhayes2
7f155a0f40
Add chmod test with incorrect mode value
2018-09-25 00:27:31 -04:00
rhayes2
294685d6cb
Style fix
2018-09-25 00:15:07 -04:00
Stephen Ward
30752c9109
added a test: open a new file for writing, and set a mode for that file
2018-09-24 23:28:56 -04:00
Stephen Ward
78b3452d5d
added the addition of an optional mode when opening a file, removed my test because it was broken. Seemingly passes all the other tests still. STILL TO DO: add a proper test which makes sure the mode is set.
2018-09-24 19:10:09 -04:00
Stephen Ward
e7811eb53b
fixed lint spaces/indentation errors
2018-09-24 17:46:01 -04:00
rhayes2
546b4567d2
Added Test for CHMODE
2018-09-24 14:16:16 -04:00
Stephen Ward
add00ce563
testing out the validateAndMask() function, with console.log's...
2018-09-23 13:49:00 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca
5e4de6b698
Fix #393 : add test for truncate with length undefined
2018-09-17 18:30:09 -04:00
David Humphrey
0e00af661a
Fix lint issues in fs.appendFile.spec.js
2018-07-27 11:02:42 -04:00
David Humphrey
f89b616fdc
Fix issues in fs.chmod.spec.js
2018-07-27 11:01:47 -04:00
David Humphrey
cbcddee3be
Fix lint issues in fs.chown.spec.js
2018-07-27 11:01:26 -04:00
David Humphrey
1a738dd2bb
Fix lint issues in fs.close.spec.js, fs.link.spec.js
2018-07-27 11:00:48 -04:00
David Humphrey
9e08d96c96
Fix lint issues in fs.lstat.spec.js
2018-07-27 10:44:42 -04:00
David Humphrey
980d5d0917
Fix lint issues in fs.lseek.spec.js
2018-07-27 10:43:51 -04:00
David Humphrey
a8e373e4b9
Fix lint issues in fs.mknod.spec.js
2018-07-27 10:39:34 -04:00
David Humphrey
86e57d60db
Fix lint issues in fs.open.spec.js
2018-07-27 10:38:44 -04:00
David Humphrey
054094c852
Fix lint issues in fs.read.spec.js, fix test failure in fs.stats.spec.js
2018-07-27 10:37:45 -04:00