LumeWeb
/
filer
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update https://github.com/filerjs/filer/pull/485 to master, add tests + fix.

This commit is contained in:
David Humphrey 2018-12-14 22:05:51 -05:00
parent 94fd5ba829 31b3c40d74
commit acef2c93b0
2 changed files with 76 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/filesystem/implementation.js
View File

@ -2184,14 +2184,14 @@ function futimes(fs, context, fd, atime, mtime, callback) {
function chmod(fs, context, path, mode, callback) {
if(!pathCheck(path, callback)) return;
mode = validateAndMaskMode(mode, 'mode');
mode = validateAndMaskMode(mode, 'mode', callback);
if(!mode) return;
chmod_file(context, path, mode, callback);
}
function fchmod(fs, context, fd, mode, callback) {
mode = validateAndMaskMode(mode, 'mode');
mode = validateAndMaskMode(mode, 'mode', callback);
if(!mode) return;
var ofd = fs.openFiles[fd];

74
tests/spec/fs.chmod.spec.js
View File

@ -46,7 +46,81 @@ describe('fs.chmod, fs.fchmod', function() {
expect(err.code).to.equal('ENOENT');
done();
});
});
it('should error if mode value is a non-numeric string', function(done) {
var fs = util.fs();
fs.mkdir('/dir', function(err) {
if(err) throw err;
fs.chmod('/dir', 'mode', function(err) {
expect(err).to.exist;
expect(err.code).to.equal('EINVAL');
done();
});
});
});
it('should error if mode value is null', function(done) {
var fs = util.fs();
fs.mkdir('/dir', function(err) {
if(err) throw err;
fs.chmod('/dir', 'null', function(err) {
expect(err).to.exist;
expect(err.code).to.equal('EINVAL');
done();
});
});
});
it('should error if mode value is non-integer number', function(done) {
var fs = util.fs();
fs.mkdir('/dir', function(err) {
if(err) throw err;
fs.chmod('/dir', 3.14, function(err) {
expect(err).to.exist;
expect(err.code).to.equal('EINVAL');
done();
});
});
});
it('should error if mode value is non-integer number', function(done) {
var fs = util.fs();
fs.mkdir('/dir', function(err) {
if(err) throw err;
fs.chmod('/dir', 3.14, function(err) {
expect(err).to.exist;
expect(err.code).to.equal('EINVAL');
done();
});
});
});
it('should allow octal strings for mode value', function(done) {
var fs = util.fs();
fs.mkdir('/dir', function(err) {
if(err) throw err;
fs.chmod('/dir', '777', function(err) {
if(err) throw err;
fs.stat('/dir/', function(err, stats) {
if(err) throw err;
expect(stats.mode & 0o777).to.equal(0o777);
done();
});
});
});
});
it('should allow for updating mode of a given file', function(done) {