From ab0b667ff38203d3d2c6a7e5618f560ad0c1aa18 Mon Sep 17 00:00:00 2001 From: Rob Wu Date: Sun, 20 Aug 2017 13:26:43 +0200 Subject: [PATCH] fix: Lock gruntify-eslint version to fix build errors (#42) * Lock version of gruntify-eslint (and grunt-replace) The current repository is compatible with gruntify-eslint 3.1.0. `*` resolves to version 4.0.0., which bumps its eslint dependency from 3.x to 4.x, which in turn causes linting errors. To get the default check-out to pass, lock the dependencies to known-compatible versions. * Bump gruntify-eslint to 4.0.0 + fix lint error Bump gruntify-eslint to 4.0.0, which depends on eslint ^4.0.0, and fix the lint error that appeared. --- Gruntfile.js | 4 ++-- package.json | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Gruntfile.js b/Gruntfile.js index 7425fcc..4d80515 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -33,8 +33,8 @@ module.exports = function(grunt) { match: /\{\/\* include\("(.*?)"\) \*\/\}/, replacement: (match, filename) => { return grunt.file.read(filename) - .replace(/\n$/, "") - .replace(/^[^{]/gm, " $&"); + .replace(/\n$/, "") + .replace(/^[^{]/gm, " $&"); }, }, { diff --git a/package.json b/package.json index bb65a7c..55cf2a3 100644 --- a/package.json +++ b/package.json @@ -25,8 +25,8 @@ "grunt-babel": "^6.0.0", "grunt-contrib-concat": "^1.0.1", "grunt-coveralls": "^1.0.1", - "grunt-replace": "*", - "gruntify-eslint": "*", + "grunt-replace": "^1.0.1", + "gruntify-eslint": "^4.0.0", "istanbul-lib-instrument": "^1.1.3", "jsdom": "^9.6.0", "mocha": "^3.1.0",