LumeWeb
/
webextension-polyfill
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: pluralize argument in raised error message

This commit is contained in:
Luca Greco 2016-11-02 21:45:02 +01:00
parent 705e93bc2f
commit 9a04fc3876
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
browser-polyfill.in.js
View File

@ -105,13 +105,15 @@ if (typeof browser === "undefined") {
* The generated wrapper function. * The generated wrapper function.
*/ */
const wrapAsyncFunction = (name, metadata) => { const wrapAsyncFunction = (name, metadata) => {
const pluralizeArguments = (numArgs) => numArgs == 1 ? "argument" : "arguments";
return function asyncFunctionWrapper(target, ...args) { return function asyncFunctionWrapper(target, ...args) {
if (args.length < metadata.minArgs) { if (args.length < metadata.minArgs) {
throw new Error(`Expected at least ${metadata.minArgs} arguments for ${name}(), got ${args.length}`); throw new Error(`Expected at least ${metadata.minArgs} ${pluralizeArguments(metadata.minArgs)} for ${name}(), got ${args.length}`);
} }
if (args.length > metadata.maxArgs) { if (args.length > metadata.maxArgs) {
throw new Error(`Expected at most ${metadata.maxArgs} arguments for ${name}(), got ${args.length}`); throw new Error(`Expected at most ${metadata.maxArgs} ${pluralizeArguments(metadata.maxArgs)} for ${name}(), got ${args.length}`);
} }
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {

2
test/test-async-functions.js
View File

@ -79,7 +79,7 @@ describe("browser-polyfill", () => {
return setupTestDOMWindow(fakeChrome).then(window => { return setupTestDOMWindow(fakeChrome).then(window => {
throws(() => { throws(() => {
window.browser.runtime.sendMessage(); window.browser.runtime.sendMessage();
}, "Expected at least 1 arguments for sendMessage(), got 0"); }, "Expected at least 1 argument for sendMessage(), got 0");
throws(() => { throws(() => {
window.browser.runtime.sendMessage("0", "1", "2", "3"); window.browser.runtime.sendMessage("0", "1", "2", "3");