From 1e596f0864245acded7459efbd30339290a38a59 Mon Sep 17 00:00:00 2001 From: Luca Greco Date: Thu, 24 Mar 2022 18:36:11 +0100 Subject: [PATCH] chore(ci): Updated circleci to use the new cimg/node docker images (#371) - migrate to the cimg/node docker image - added (and invoked) the circleci/browser-tools-org (needed to be able to run the integration tests on Firefox and Chrome) - update chromedriver to v99 and geckodriver to v3 (to make sure they will support also more recent version of Firefox and Chrome) --- .circleci/config.yml | 13 ++++++++++--- package.json | 4 ++-- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 77983ff..efe5c39 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -16,9 +16,15 @@ version: 2.1 orbs: codecov: codecov/codecov@3.2.2 + browser-tools: circleci/browser-tools@1.1.0 references: - nodejs_current: &nodejs_current "12" + # See https://hub.docker.com/r/cimg/node/tags for the nodejs versions + # available. + # + # TODO: not listing the docker image explicitly is likely to prevent + # renovatebot from being able to automatically create PRs to update it. + nodejs_current: &nodejs_current "12.22" repo_path: &repo_path ~/webextension-polyfill defaults: &defaults working_directory: *repo_path @@ -131,8 +137,9 @@ jobs: <<: *defaults docker: # Image variant including Firefox, Chrome and Xvfb - - image: circleci/node:<< parameters.nodejs_current >>-browsers + - image: cimg/node:<< parameters.nodejs_current >>-browsers steps: + - browser-tools/install-browser-tools - attach_project_repo - checkout - run_npm_install @@ -144,7 +151,7 @@ jobs: release-tag: <<: *defaults docker: - - image: circleci/node:<< parameters.nodejs_current >> + - image: cimg/node:<< parameters.nodejs_current >> steps: - attach_project_repo - run_npm_build: diff --git a/package.json b/package.json index ce210bb..d0fd515 100644 --- a/package.json +++ b/package.json @@ -24,11 +24,11 @@ "babel-preset-minify": "0.5.1", "browserify": "17.0.0", "chai": "4.3.4", - "chromedriver": "96.0.0", + "chromedriver": "99.0.0", "cross-env": "7.0.3", "eslint": "7.25.0", "finalhandler": "1.1.2", - "geckodriver": "1.22.3", + "geckodriver": "3.0.1", "global-replaceify": "1.0.0", "grunt": "1.4.0", "grunt-babel": "8.0.0",