From f3c38dea8ee3de590ef9ee2535a1a8cfb2544321 Mon Sep 17 00:00:00 2001
From: Derrick Hammer <derrick@derrickhammer.com>
Date: Wed, 27 Dec 2023 11:41:13 -0500
Subject: [PATCH] fix: prevent duplicate tags

---
 app/lib/meta.ts | 50 ++++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 43 insertions(+), 7 deletions(-)

diff --git a/app/lib/meta.ts b/app/lib/meta.ts
index a82901e..b9a5628 100644
--- a/app/lib/meta.ts
+++ b/app/lib/meta.ts
@@ -11,7 +11,6 @@ interface GenerateMetaTagsParams {
   ogType?: "website" | "article";
   parentMeta?: ServerRuntimeMetaArgs;
 }
-
 export function generateMetaTags({
   title,
   description,
@@ -19,14 +18,44 @@ export function generateMetaTags({
   ogType = "website",
   parentMeta,
 }: GenerateMetaTagsParams) {
-  let parentMetaMerged: ServerRuntimeMetaDescriptor[] = [];
+  const metaTags: Record<string, ServerRuntimeMetaDescriptor> = {};
 
-  if (parentMeta?.matches) {
-    parentMetaMerged = parentMeta?.matches.flatMap((match) => match.meta ?? []);
-  }
+  // Helper function to generate a unique key for each meta tag
+  const generateKey = (tag: ServerRuntimeMetaDescriptor): string => {
+    if ("name" in tag && tag.name) {
+      return `name:${tag.name}`;
+    }
+    if ("property" in tag && tag.property) {
+      return `property:${tag.property}`;
+    }
+    if ("httpEquiv" in tag && tag.httpEquiv)
+      return `httpEquiv:${tag.httpEquiv}`;
+    if ("charSet" in tag) {
+      return "charSet";
+    }
+    if ("title" in tag) {
+      return "title";
+    }
+    if ("script:ld+json" in tag) {
+      return "script:ld+json";
+    }
+    if ("tagName" in tag && tag.tagName) {
+      return `tagName:${tag.tagName}`;
+    }
+    // Fallback for complex or unknown types - convert to JSON string
+    return `unknown:${JSON.stringify(tag)}`;
+  };
 
-  return [
-    ...parentMetaMerged,
+  // Merge parent meta tags
+  parentMeta?.matches?.forEach((match) => {
+    match.meta?.forEach((tag) => {
+      const key = generateKey(tag);
+      metaTags[key] = tag;
+    });
+  });
+
+  // Define new meta tags and add or overwrite them in the metaTags object
+  const newMetaTags: ServerRuntimeMetaDescriptor[] = [
     { title },
     { name: "title", content: title },
     { name: "description", content: description },
@@ -35,4 +64,11 @@ export function generateMetaTags({
     { name: "og:image", content: imageUrl },
     { name: "og:type", content: ogType },
   ];
+
+  newMetaTags.forEach((tag) => {
+    const key = generateKey(tag);
+    metaTags[key] = tag;
+  });
+
+  return Object.values(metaTags);
 }