From e138fc3e9e01ab8294a393ec0407eff38a708ddb Mon Sep 17 00:00:00 2001 From: oliverpool Date: Wed, 23 Oct 2019 18:51:36 +0200 Subject: [PATCH] filestore: Remove useless defer (#318) Since the `file` is not used after the creation, its closing can be done without defer (and the err can be checked). --- pkg/filestore/filestore.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/filestore/filestore.go b/pkg/filestore/filestore.go index 24a186b..c2273b1 100644 --- a/pkg/filestore/filestore.go +++ b/pkg/filestore/filestore.go @@ -65,7 +65,10 @@ func (store FileStore) NewUpload(ctx context.Context, info handler.FileInfo) (ha } return nil, err } - defer file.Close() + err = file.Close() + if err != nil { + return nil, err + } upload := &fileUpload{ info: info,