From e276384a487f793a9dfdd70d1fa9aeece1c3cd6d Mon Sep 17 00:00:00 2001 From: Adam Jensen Date: Tue, 24 Apr 2018 11:47:29 -0400 Subject: [PATCH 1/2] Remove misleading comment The comment mentions 6, but the relevant sizes are 5MB, 5GB, and 5TB. I think it's preferable to let the code speak for itself so that the comment doesn't become stale. --- s3store/s3store.go | 1 - 1 file changed, 1 deletion(-) diff --git a/s3store/s3store.go b/s3store/s3store.go index 3b9465e..279060a 100644 --- a/s3store/s3store.go +++ b/s3store/s3store.go @@ -150,7 +150,6 @@ type S3API interface { } // New constructs a new storage using the supplied bucket and service object. -// The MaxPartSize and MinPartSize properties are set to 6 and 5MB. func New(bucket string, service S3API) S3Store { return S3Store{ Bucket: bucket, From 450a60633454c97f6b3a18d870a3768cfb50b31f Mon Sep 17 00:00:00 2001 From: Adam Jensen Date: Tue, 24 Apr 2018 11:53:36 -0400 Subject: [PATCH 2/2] Fix a couple of typos --- s3store/s3store.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/s3store/s3store.go b/s3store/s3store.go index 279060a..3d0ad98 100644 --- a/s3store/s3store.go +++ b/s3store/s3store.go @@ -39,7 +39,7 @@ // Therefore, HEAD responses will always contain the unchanged metadata, Base64- // encoded, even if it contains non-ASCII characters. // -// Once the upload is finish, the multipart upload is completed, resulting in +// Once the upload is finished, the multipart upload is completed, resulting in // the entire file being stored in the bucket. The info object, containing // meta data is not deleted. It is recommended to copy the finished upload to // another bucket to avoid it being deleted by the Termination extension. @@ -58,7 +58,7 @@ // be 5MB or bigger. This introduces a problem, since in tus' perspective // it's totally fine to upload just a few kilobytes in a single request. // -// Therefore, a few special condition have been implemented: +// Therefore, a few special conditions have been implemented: // // Each PATCH request must contain a body of, at least, 5MB. If the size // is smaller than this limit, the entire request will be dropped and not