LumeWeb
/
tusd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify lock logic

This commit is contained in:
oliverpool 2017-02-02 08:25:42 +01:00
parent d7a4619080
commit 3d9395e1df
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
metrics.go
View File

@ -88,12 +88,13 @@ func newErrorsTotalMap() ErrorsTotalMap {
// incErrorsTotal increases the counter for this error atomically by one. // incErrorsTotal increases the counter for this error atomically by one.
func (e *ErrorsTotalMap) incError(err HTTPError) { func (e *ErrorsTotalMap) incError(err HTTPError) {
// The goal is to have a valid ptr to the number of HTTPError // The goal is to have a valid ptr to the counter for this err
e.RLock() e.RLock()
if ptr, ok := e.m[err]; !ok { ptr, ok := e.m[err]
e.RUnlock()
if !ok {
// The ptr does not seem to exist for this err // The ptr does not seem to exist for this err
// Hence we create it (using a write lock) // Hence we create it (using a write lock)
e.RUnlock()
e.Lock() e.Lock()
// We ensure that the ptr wasn't created in the meantime // We ensure that the ptr wasn't created in the meantime
if ptr, ok = e.m[err]; !ok { if ptr, ok = e.m[err]; !ok {
@ -102,8 +103,6 @@ func (e *ErrorsTotalMap) incError(err HTTPError) {
e.m[err] = ptr e.m[err] = ptr
} }
e.Unlock() e.Unlock()
} else {
e.RUnlock()
} }
// We can then increase the counter // We can then increase the counter
atomic.AddUint64(e.m[err], 1) atomic.AddUint64(e.m[err], 1)