Merge branch 'master' into add-shell-scripts-lint

.github/workflows/lint-shell-scripts.yml

@@ -0,0 +1,14 @@
+name: Lint Shell Scripts
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+
+jobs:
+  shellcheck:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: ludeeus/action-shellcheck@1.1.0

scripts/blocklist-skylink.sh

@@ -26,8 +26,8 @@ if test -f "$1"; then
         else
             echo "Incorrect skylink at line ${line_number}: $line" && exit 1
         fi
-        let line_number+=1
-    done < $1;
+        (( line_number++ ))
+    done < "$1";
 else
     skylinks=("$1") # just single skylink passed as input argument
 fi

scripts/portal-down.sh

@@ -20,7 +20,7 @@ fi
 
 countdown() {
     local secs=$1
-    while [ $secs -gt 0 ]; do
+    while [ "$secs" -gt 0 ]; do
         echo -ne "Waiting $secs\033[0K\r"
         sleep 1
         : $((secs--))
@@ -28,10 +28,10 @@ countdown() {
 }
 
 # delay disabling the portal
-countdown $delay
+countdown "$delay"
 
 # stop health-check so the server is taken our of load balancer
-docker exec health-check cli disable $reason
+docker exec health-check cli disable "$reason"
 
 # then wait 5 minutes for the load balancer to propagate the dns records
-countdown $timeout
+countdown "$timeout"

setup-scripts/serverload.sh

@@ -33,7 +33,7 @@ fi
 # Write the output in an infinite loop.
 while true; do
     # CPU usage
-    cpu=$(echo $[100-$(vmstat 1 2|tail -1|awk '{print $15}')]) 
+    cpu=$((100-$(vmstat 1 2|tail -1|awk '{print $15}')))
     sed -i "1iCPU: ${cpu}" $logfile
 
     # Disk Usage