From 0ec9b396aa46b40af19e1c42f67a9cef68fea31c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Leszczyk?= Date: Mon, 14 Mar 2022 16:58:45 +0100 Subject: [PATCH 01/16] fix(dashboard-v2): styling fixes for active link in navbar dropdown --- .../src/components/DropdownMenu/DropdownMenuLink.js | 12 +++++------- .../dashboard-v2/src/components/NavBar/NavBar.js | 10 ++++++++-- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/packages/dashboard-v2/src/components/DropdownMenu/DropdownMenuLink.js b/packages/dashboard-v2/src/components/DropdownMenu/DropdownMenuLink.js index 45a86483..426501c4 100644 --- a/packages/dashboard-v2/src/components/DropdownMenu/DropdownMenuLink.js +++ b/packages/dashboard-v2/src/components/DropdownMenu/DropdownMenuLink.js @@ -3,18 +3,16 @@ import PropTypes from "prop-types"; const DropdownLink = styled.a.attrs({ className: `m-0 border-t border-palette-200/50 h-[60px] - whitespace-nowrap transition-colors text-current + whitespace-nowrap transition-colors hover:bg-palette-100/50 flex items-center pr-8 pl-6 py-4 gap-4 first:border-0`, })``; export const DropdownMenuLink = ({ active, icon: Icon, label, ...props }) => ( - <> - - {Icon ? : null} - {label} - - + + {Icon ? : null} + {label} + ); DropdownMenuLink.propTypes = { diff --git a/packages/dashboard-v2/src/components/NavBar/NavBar.js b/packages/dashboard-v2/src/components/NavBar/NavBar.js index 2b53f2be..7fa52109 100644 --- a/packages/dashboard-v2/src/components/NavBar/NavBar.js +++ b/packages/dashboard-v2/src/components/NavBar/NavBar.js @@ -68,8 +68,14 @@ export const NavBar = () => ( - - + + From 60b6fd2a48502782f424474a3fdf9274c54b34d0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Leszczyk?= Date: Tue, 15 Mar 2022 15:53:02 +0100 Subject: [PATCH 02/16] fix(dashboard-v2): fix navbar dropdown hiding behind positioned content --- .../src/components/DropdownMenu/DropdownMenu.js | 2 +- packages/dashboard-v2/src/components/NavBar/NavBar.js | 11 +++++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/packages/dashboard-v2/src/components/DropdownMenu/DropdownMenu.js b/packages/dashboard-v2/src/components/DropdownMenu/DropdownMenu.js index 461a9b7e..86cbad5f 100644 --- a/packages/dashboard-v2/src/components/DropdownMenu/DropdownMenu.js +++ b/packages/dashboard-v2/src/components/DropdownMenu/DropdownMenu.js @@ -30,7 +30,7 @@ const TriggerIcon = styled(ChevronDownIcon).attrs({ `; const Flyout = styled.div.attrs(({ open }) => ({ - className: `absolute top-full right-0 p-0 + className: `absolute top-full right-0 p-0 z-10 border rounded border-palette-100 bg-white shadow-md shadow-palette-200/50 ${open ? "visible" : "invisible"}`, diff --git a/packages/dashboard-v2/src/components/NavBar/NavBar.js b/packages/dashboard-v2/src/components/NavBar/NavBar.js index 7fa52109..6cef6df5 100644 --- a/packages/dashboard-v2/src/components/NavBar/NavBar.js +++ b/packages/dashboard-v2/src/components/NavBar/NavBar.js @@ -9,7 +9,7 @@ import { PageContainer } from "../PageContainer"; import { NavBarLink, NavBarSection } from "."; const NavBarContainer = styled.div.attrs({ - className: `grid sticky top-0 bg-white`, + className: `grid sticky top-0 bg-white z-10`, })``; const NavBarBody = styled.nav.attrs({ @@ -68,7 +68,14 @@ export const NavBar = () => ( - + Date: Tue, 15 Mar 2022 15:54:10 +0100 Subject: [PATCH 03/16] feat(dashboard-v2): add global typography styles --- packages/dashboard-v2/src/styles/global.css | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/packages/dashboard-v2/src/styles/global.css b/packages/dashboard-v2/src/styles/global.css index ae86596a..e0238aad 100644 --- a/packages/dashboard-v2/src/styles/global.css +++ b/packages/dashboard-v2/src/styles/global.css @@ -39,7 +39,14 @@ font-size: 1rem; } h6 { - @apply uppercase; - font-size: 0.875rem; + @apply uppercase text-xs; + } + + p { + @apply mt-2; + } + + hr { + @apply border-t-palette-200; } } From 4a5be18dae646acbc387b57ab207eb9ef12109b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Leszczyk?= Date: Tue, 15 Mar 2022 15:54:34 +0100 Subject: [PATCH 04/16] fix(dashboard-v2): fix Switch toggle shrinking in narrow spaces --- packages/dashboard-v2/src/components/Switch/Switch.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/dashboard-v2/src/components/Switch/Switch.js b/packages/dashboard-v2/src/components/Switch/Switch.js index ed24bc92..02b361c0 100644 --- a/packages/dashboard-v2/src/components/Switch/Switch.js +++ b/packages/dashboard-v2/src/components/Switch/Switch.js @@ -21,7 +21,7 @@ const Label = styled.label.attrs({ `; const Toggle = styled.span.attrs({ - className: `flex flex-row items-center justify-between + className: `flex flex-row items-center justify-between shrink-0 w-[44px] h-[22px] bg-white rounded-full border border-palette-200 relative cursor-pointer`, })` @@ -45,7 +45,7 @@ const TogglePin = styled.span.attrs(({ $checked }) => ({ } `; -export const Switch = ({ children, defaultChecked, onChange, ...props }) => { +export const Switch = ({ children, defaultChecked, labelClassName, onChange, ...props }) => { const id = useMemo(nanoid, [onChange]); const [checked, setChecked] = useState(defaultChecked); @@ -56,7 +56,7 @@ export const Switch = ({ children, defaultChecked, onChange, ...props }) => { return ( setChecked(ev.target.checked)} id={id} /> -