From a2265cdd79e6fabf14268cc077f755e249decabb Mon Sep 17 00:00:00 2001 From: Delivator Date: Wed, 14 Oct 2020 12:55:28 +0200 Subject: [PATCH] Converting hns domain to punycode (Fix for #458) --- packages/handshake-api/src/index.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/handshake-api/src/index.js b/packages/handshake-api/src/index.js index 72aa2234..8aedab06 100644 --- a/packages/handshake-api/src/index.js +++ b/packages/handshake-api/src/index.js @@ -1,4 +1,5 @@ const express = require("express"); +const punycode = require("punycode"); const NodeCache = require("node-cache"); const { NodeClient } = require("hs-client"); @@ -51,11 +52,12 @@ const getSkylinkFromRecord = (record) => { const resolveDomainHandler = async (req, res) => { try { - const records = await getDomainRecords(req.params.name); - if (!records) return res.status(404).send(`No records found for ${req.params.name}`); + const domain = punycode.toASCII(req.params.name); + const records = await getDomainRecords(domain); + if (!records) return res.status(404).send(`No records found for ${domain}`); const record = findSkylinkRecord(records); - if (!record) throw new Error(`No skylink found in dns records of ${req.params.name}`); + if (!record) throw new Error(`No skylink found in dns records of ${domain}`); const skylink = getSkylinkFromRecord(record); return res.json({ skylink });