From 4e64ddd798fdb629b577a0ade16004ce9acb0c46 Mon Sep 17 00:00:00 2001 From: Karol Wypchlo Date: Fri, 8 Apr 2022 13:20:05 +0200 Subject: [PATCH] match lowercase true/false --- docker/nginx/libs/utils.lua | 4 ++-- docker/nginx/libs/utils.spec.lua | 12 ++++++++++++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/docker/nginx/libs/utils.lua b/docker/nginx/libs/utils.lua index 3b9b2592..8b77d802 100644 --- a/docker/nginx/libs/utils.lua +++ b/docker/nginx/libs/utils.lua @@ -61,11 +61,11 @@ function _M.getenv(name, parse) -- try to parse as boolean if parse == "boolean" then - if value == "true" or value == "1" then + if string.lower(value) == "true" or value == "1" then return true end - if value == "false" or value == "0" then + if string.lower(value) == "false" or value == "0" then return false end diff --git a/docker/nginx/libs/utils.spec.lua b/docker/nginx/libs/utils.spec.lua index af43e898..78aa0833 100644 --- a/docker/nginx/libs/utils.spec.lua +++ b/docker/nginx/libs/utils.spec.lua @@ -135,6 +135,12 @@ describe("getenv", function() assert.is_true(utils.getenv("foo", "boolean")) end) + it("should parse 'True' string as true", function() + os.getenv.on_call_with("foo").returns("True") + + assert.is_true(utils.getenv("foo", "boolean")) + end) + it("should parse '1' string as true", function() os.getenv.on_call_with("foo").returns("1") @@ -147,6 +153,12 @@ describe("getenv", function() assert.is_false(utils.getenv("foo", "boolean")) end) + it("should parse 'False' string as false", function() + os.getenv.on_call_with("foo").returns("False") + + assert.is_false(utils.getenv("foo", "boolean")) + end) + it("should parse '0' string as false", function() os.getenv.on_call_with("foo").returns("0")