From 4096a7ebf22b5ae6e939cb0b17d521f637b12aaa Mon Sep 17 00:00:00 2001 From: PJ Date: Mon, 17 Jan 2022 13:40:39 +0100 Subject: [PATCH] Delete ip property from check --- packages/health-check/src/checks/critical.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/health-check/src/checks/critical.js b/packages/health-check/src/checks/critical.js index 75ca6d4d..5384d8a6 100644 --- a/packages/health-check/src/checks/critical.js +++ b/packages/health-check/src/checks/critical.js @@ -180,14 +180,17 @@ async function blockerHealthCheck(done) { data.statusCode = response.statusCode; data.response = response.body; data.up = response.body.dbAlive === true; - data.ip = response.ip; } catch (error) { data.statusCode = error?.response?.statusCode || error.statusCode || error.status; data.errorMessage = error.message; data.errorResponseContent = getResponseContent(error.response); - data.ip = error?.response?.ip ?? null; } + // this is a no-op but it's added to explicitly document the ip property + // should not be set on the data object to prevent the IP from being compared + // to the server's IP - this is not required for this check and will fail + delete data.ip + done({ name: "blocker", time: calculateElapsedTime(time), ...data }); }