LumeWeb
/
portal
1
0
Fork 0
Code Issues 5 Pull Requests Packages Projects Releases Wiki Activity

refactor: standardize errors to global error objects

This commit is contained in:
Derrick Hammer 2023-06-09 06:24:42 -04:00
parent d1d4f6b679
commit 9e52cd671b
Signed by: pcfreak30
GPG Key ID: C997C339BE476FF2
1 changed files with 55 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
service/files/files.go
View File

@ -16,6 +16,7 @@ import (
"github.com/spf13/viper" "github.com/spf13/viper"
_ "github.com/tus/tusd/pkg/handler" _ "github.com/tus/tusd/pkg/handler"
"go.uber.org/zap" "go.uber.org/zap"
"gorm.io/gorm"
"io" "io"
"strings" "strings"
) )
@ -26,6 +27,22 @@ const (
STATUS_NOT_FOUND = iota STATUS_NOT_FOUND = iota
) )
var (
ErrAlreadyExists = errors.New("Upload already exists")
ErrFailedFetchObject = errors.New("Failed fetching object")
ErrFailedFetchObjectProof = errors.New("Failed fetching object proof")
ErrFailedFetchTusObject = errors.New("Failed fetching tus object")
ErrFailedHashFile = errors.New("Failed to hash file")
ErrFailedQueryTusUpload = errors.New("Failed to query tus uploads")
ErrFailedQueryUpload = errors.New("Failed to query uploads table")
ErrFailedSaveUpload = errors.New("Failed saving upload to db")
ErrFailedUpload = errors.New("Failed uploading object")
ErrFailedUploadProof = errors.New("Failed uploading object proof")
ErrFileExistsOutOfSync = errors.New("File already exists in network, but missing in database")
ErrFileHashMismatch = errors.New("File hash does not match provided file hash")
ErrInvalidFile = errors.New("Invalid file")
)
var client *resty.Client var client *resty.Client
func Init() { func Init() {
@ -41,14 +58,14 @@ func Upload(r io.ReadSeeker, size int64, hash []byte) (model.Upload, error) {
tree, hashBytes, err := bao.ComputeTree(r, size) tree, hashBytes, err := bao.ComputeTree(r, size)
if err != nil { if err != nil {
logger.Get().Error("Failed to hash file", zap.Error(err)) logger.Get().Error(ErrFailedHashFile.Error(), zap.Error(err))
return upload, err return upload, ErrFailedHashFile
} }
if hash != nil { if hash != nil {
if bytes.Compare(hashBytes[:], hash) != 0 { if bytes.Compare(hashBytes[:], hash) != 0 {
logger.Get().Error("File hash does not match provided file hash") logger.Get().Error(ErrFileHashMismatch.Error())
return upload, err return upload, ErrFileHashMismatch
} }
} }
@ -61,15 +78,15 @@ func Upload(r io.ReadSeeker, size int64, hash []byte) (model.Upload, error) {
} }
result := db.Get().Where(&model.Upload{Hash: hashHex}).First(&upload) result := db.Get().Where(&model.Upload{Hash: hashHex}).First(&upload)
if (result.Error != nil && result.Error.Error() != "record not found") || result.RowsAffected > 0 { if (result.Error != nil && !errors.Is(result.Error, gorm.ErrRecordNotFound)) || result.RowsAffected > 0 {
err := result.Row().Scan(&upload) err := result.Row().Scan(&upload)
if err != nil { if err != nil {
logger.Get().Error("Failed to query uploads table", zap.Error(err)) logger.Get().Error(ErrFailedQueryUpload.Error(), zap.Error(err))
return upload, err return upload, ErrFailedQueryUpload
} }
if result.RowsAffected > 0 && upload.ID > 0 { if result.RowsAffected > 0 && upload.ID > 0 {
logger.Get().Info("Upload already exists") logger.Get().Info(ErrAlreadyExists.Error())
return upload, nil return upload, nil
} }
} }
@ -77,8 +94,8 @@ func Upload(r io.ReadSeeker, size int64, hash []byte) (model.Upload, error) {
objectExistsResult, err := client.R().Get(getBusObjectUrl(hashHex)) objectExistsResult, err := client.R().Get(getBusObjectUrl(hashHex))
if err != nil { if err != nil {
logger.Get().Error("Failed query object", zap.Error(err)) logger.Get().Error(ErrFailedQueryUpload.Error(), zap.Error(err))
return upload, err return upload, ErrFailedQueryUpload
} }
objectStatusCode := objectExistsResult.StatusCode() objectStatusCode := objectExistsResult.StatusCode()
@ -86,8 +103,8 @@ func Upload(r io.ReadSeeker, size int64, hash []byte) (model.Upload, error) {
if objectStatusCode == 500 { if objectStatusCode == 500 {
bodyErr := objectExistsResult.String() bodyErr := objectExistsResult.String()
if !strings.Contains(bodyErr, "no slabs found") { if !strings.Contains(bodyErr, "no slabs found") {
logger.Get().Error("Failed fetching object", zap.String("error", objectExistsResult.String())) logger.Get().Error(ErrFailedFetchObject.Error(), zap.String("error", objectExistsResult.String()))
return upload, errors.New(fmt.Sprintf("error fetching file: %s", objectExistsResult.String())) return upload, ErrFailedFetchObject
} }
objectStatusCode = 404 objectStatusCode = 404
@ -96,8 +113,8 @@ func Upload(r io.ReadSeeker, size int64, hash []byte) (model.Upload, error) {
proofExistsResult, err := client.R().Get(getBusProofUrl(hashHex)) proofExistsResult, err := client.R().Get(getBusProofUrl(hashHex))
if err != nil { if err != nil {
logger.Get().Error("Failed query object proof", zap.Error(err)) logger.Get().Error(ErrFailedFetchObjectProof.Error(), zap.Error(err))
return upload, err return upload, ErrFailedFetchObjectProof
} }
proofStatusCode := proofExistsResult.StatusCode() proofStatusCode := proofExistsResult.StatusCode()
@ -105,31 +122,28 @@ func Upload(r io.ReadSeeker, size int64, hash []byte) (model.Upload, error) {
if proofStatusCode == 500 { if proofStatusCode == 500 {
bodyErr := proofExistsResult.String() bodyErr := proofExistsResult.String()
if !strings.Contains(bodyErr, "no slabs found") { if !strings.Contains(bodyErr, "no slabs found") {
logger.Get().Error("Failed fetching object proof", zap.String("error", proofExistsResult.String())) logger.Get().Error(ErrFailedFetchObjectProof.Error(), zap.String("error", proofExistsResult.String()))
return upload, errors.New(fmt.Sprintf("error fetching file proof: %s", proofExistsResult.String())) return upload, ErrFailedFetchObjectProof
} }
objectStatusCode = 404 objectStatusCode = 404
} }
if objectStatusCode != 404 && proofStatusCode != 404 { if objectStatusCode != 404 && proofStatusCode != 404 {
msg := "file already exists in network, but missing in database" logger.Get().Error(ErrFileExistsOutOfSync.Error(), zap.String("hash", hashHex))
logger.Get().Error(msg) return upload, ErrFileExistsOutOfSync
return upload, errors.New(msg)
} }
ret, err := client.R().SetBody(r).Put(getWorkerObjectUrl(hashHex)) ret, err := client.R().SetBody(r).Put(getWorkerObjectUrl(hashHex))
if ret.StatusCode() != 200 { if ret.StatusCode() != 200 {
logger.Get().Error("Failed uploading object", zap.String("error", ret.String())) logger.Get().Error(ErrFailedUpload.Error(), zap.String("error", ret.String()))
err = errors.New(ret.String()) return upload, ErrFailedUpload
return upload, err
} }
ret, err = client.R().SetBody(tree).Put(getWorkerProofUrl(hashHex)) ret, err = client.R().SetBody(tree).Put(getWorkerProofUrl(hashHex))
if ret.StatusCode() != 200 { if ret.StatusCode() != 200 {
logger.Get().Error("Failed uploading proof", zap.String("error", ret.String())) logger.Get().Error(ErrFailedUploadProof.Error(), zap.String("error", ret.String()))
err = errors.New(ret.String()) return upload, ErrFailedUpload
return upload, err
} }
upload = model.Upload{ upload = model.Upload{
@ -137,8 +151,8 @@ func Upload(r io.ReadSeeker, size int64, hash []byte) (model.Upload, error) {
} }
if err = db.Get().Create(&upload).Error; err != nil { if err = db.Get().Create(&upload).Error; err != nil {
logger.Get().Error("Failed adding upload to db", zap.Error(err)) logger.Get().Error(ErrFailedSaveUpload.Error(), zap.Error(err))
return upload, err return upload, ErrFailedSaveUpload
} }
return upload, nil return upload, nil
@ -150,8 +164,8 @@ func Download(hash string) (io.Reader, error) {
if uploadItem.Err() == nil { if uploadItem.Err() == nil {
fetch, err := client.R().SetDoNotParseResponse(true).Get(fmt.Sprintf("/worker/objects/%s", hash)) fetch, err := client.R().SetDoNotParseResponse(true).Get(fmt.Sprintf("/worker/objects/%s", hash))
if err != nil { if err != nil {
logger.Get().Error("Failed downloading object", zap.Error(err)) logger.Get().Error(ErrFailedFetchObject.Error(), zap.Error(err))
return nil, err return nil, ErrFailedFetchObject
} }
return fetch.RawBody(), nil return fetch.RawBody(), nil
@ -159,26 +173,26 @@ func Download(hash string) (io.Reader, error) {
var tusData model.Tus var tusData model.Tus
err := tusItem.Scan(&tusData) err := tusItem.Scan(&tusData)
if err != nil { if err != nil {
logger.Get().Error("Failed querying upload from db", zap.Error(err)) logger.Get().Error(ErrFailedQueryUpload.Error(), zap.Error(err))
return nil, err return nil, ErrFailedQueryUpload
} }
upload, err := getStore().GetUpload(context.Background(), tusData.UploadID) upload, err := getStore().GetUpload(context.Background(), tusData.UploadID)
if err != nil { if err != nil {
logger.Get().Error("Failed querying tus upload", zap.Error(err)) logger.Get().Error(ErrFailedQueryTusUpload.Error(), zap.Error(err))
return nil, err return nil, ErrFailedQueryTusUpload
} }
reader, err := upload.GetReader(context.Background()) reader, err := upload.GetReader(context.Background())
if err != nil { if err != nil {
logger.Get().Error("Failed reading tus upload", zap.Error(err)) logger.Get().Error(ErrFailedFetchTusObject.Error(), zap.Error(err))
return nil, err return nil, ErrFailedFetchTusObject
} }
return reader, nil return reader, nil
} else { } else {
logger.Get().Error("invalid file") logger.Get().Error(ErrInvalidFile.Error(), zap.String("hash", hash))
return nil, errors.New("invalid file") return nil, ErrInvalidFile
} }
} }
@ -187,8 +201,8 @@ func Status(hash string) int {
uploadItem := db.Get().Table("uploads").Where(&model.Upload{Hash: hash}).Count(&count) uploadItem := db.Get().Table("uploads").Where(&model.Upload{Hash: hash}).Count(&count)
if uploadItem.Error != nil { if uploadItem.Error != nil && !errors.Is(uploadItem.Error, gorm.ErrRecordNotFound) {
logger.Get().Error("Failed querying upload from db", zap.Error(uploadItem.Error)) logger.Get().Error(ErrFailedQueryUpload.Error(), zap.Error(uploadItem.Error))
} }
if count > 0 { if count > 0 {
@ -197,8 +211,8 @@ func Status(hash string) int {
tusItem := db.Get().Table("tus").Where(&model.Tus{Hash: hash}).Count(&count) tusItem := db.Get().Table("tus").Where(&model.Tus{Hash: hash}).Count(&count)
if tusItem.Error != nil { if tusItem.Error != nil && !errors.Is(tusItem.Error, gorm.ErrRecordNotFound) {
logger.Get().Error("Failed querying upload from db", zap.Error(tusItem.Error)) logger.Get().Error(ErrFailedQueryUpload.Error(), zap.Error(tusItem.Error))
} }
if count > 0 { if count > 0 {