refactor: change SaveUpload to use gorm create or selective Updates

metadata/metadata.go

@@ -77,22 +77,52 @@ func (m *MetadataServiceDefault) SaveUpload(ctx context.Context, metadata Upload
 	ret := m.db.WithContext(ctx).Model(&models.Upload{}).Where(&upload).First(&upload)
 
 	if ret.Error != nil {
-		if !errors.Is(ret.Error, gorm.ErrRecordNotFound) {
+		if errors.Is(ret.Error, gorm.ErrRecordNotFound) && ret.RowsAffected > 0 {
-			return ret.Error
+			return m.createUpload(ctx, metadata)
 		}
+		return ret.Error
 	}
 
-	if ret.RowsAffected > 0 {
+	changed := false
-		return nil
+
+	if upload.UserID != metadata.UserID {
+		changed = true
 	}
 
-	upload.UserID = metadata.UserID
+	if upload.MimeType != metadata.MimeType {
-	upload.MimeType = metadata.MimeType
+		changed = true
-	upload.Protocol = metadata.Protocol
+	}
-	upload.UploaderIP = metadata.UploaderIP
-	upload.Size = metadata.Size
 
-	return m.db.Save(&metadata).Error
+	if upload.Protocol != metadata.Protocol {
+		changed = true
+	}
+
+	if upload.UploaderIP != metadata.UploaderIP {
+		changed = true
+	}
+
+	if upload.Size != metadata.Size {
+		changed = true
+	}
+
+	if changed {
+		return m.db.Updates(&upload).Error
+	}
+
+	return nil
+}
+
+func (m *MetadataServiceDefault) createUpload(ctx context.Context, metadata UploadMetadata) error {
+	upload := models.Upload{
+		UserID:     metadata.UserID,
+		Hash:       metadata.Hash,
+		MimeType:   metadata.MimeType,
+		Protocol:   metadata.Protocol,
+		UploaderIP: metadata.UploaderIP,
+		Size:       metadata.Size,
+	}
+
+	return m.db.WithContext(ctx).Create(&upload).Error
 }
 
 func (m *MetadataServiceDefault) GetUpload(ctx context.Context, objectHash []byte) (UploadMetadata, error) {