Pinning System Improvements #19

New Issue

pcfreak30 · 2024-03-23T14:29:50Z

pcfreak30 commented

2024-03-23 14:29:50 +00:00

The following needs to be worked on:

Pinning form should be a text area
Since it will bulk process it should
- Lock out from exiting (no foreground exit, no x)
- Show processing X / Y
- Give notifications on every pin that failed, and process them. Unclear if we should do that in parallel?
We should not be able to undo an in-progress pinning. There is no way to undo it.
Completed items should have a unpin/undo.
A completed pin should refresh the file table.

Many small cids can be tested from here:

https://cid.one/#z5TTvXtbkQk9PTUN8r5oNSz5Trmf1NjJwkVoNvfawGKDtPCB

Small files will take seconds to pin, only the large files will really have a progress bar.

Errors returned from S5Client are refine compatible (HttpError).

The following needs to be worked on: * Pinning form should be a text area * Since it will bulk process it should * Lock out from exiting (no foreground exit, no x) * Show processing X / Y * Give notifications on every pin that failed, and process them. Unclear if we should do that in parallel? * We should not be able to undo an in-progress pinning. There is no way to undo it. * Completed items should have a unpin/undo. * A completed pin should refresh the file table. Many small cids can be tested from here: https://cid.one/#z5TTvXtbkQk9PTUN8r5oNSz5Trmf1NjJwkVoNvfawGKDtPCB Small files will take seconds to pin, only the large files will really have a progress bar. Errors returned from S5Client are refine compatible (`HttpError`).

pcfreak30 added this to the Q1 milestone 2024-03-23 14:29:50 +00:00

pcfreak30 added the

ui

label 2024-03-23 14:29:50 +00:00

ditorodev was assigned by pcfreak30

2024-03-23 14:29:50 +00:00

pcfreak30 added this to the Portal project 2024-03-23 14:29:50 +00:00

ditorodev commented

2024-03-27 06:24:17 +00:00

Need to reliably be able to pin currently for me on localhost the request is hanging (pending)

Need to reliably be able to pin currently for me on localhost the request is hanging (pending) ![image](/attachments/89de83df-3a4e-4b60-b222-adc4e0a4cd12)

image.png

575 KiB

ditorodev commented

2024-03-27 06:25:51 +00:00

Ok this worked once but i see the error you mentioned, the issues is that we are expecting a response from the pin endpoint. The thing is that when that response arrives the file is already pinned so no need for the pinning UI

Ok this worked once but i see the error you mentioned, the issues is that we are expecting a response from the `pin` endpoint. The thing is that when that response arrives the file is already pinned so no need for the pinning UI

pcfreak30 commented

2024-03-27 10:15:48 +00:00

Ok this worked once but i see the error you mentioned, the issues is that we are expecting a response from the pin endpoint. The thing is that when that response arrives the file is already pinned so no need for the pinning UI

Small files get pinned near instantly. The hang is it searching the network for the file then queing it.

Realistically need to test anything over 100 MB. One thing you could do is optimistically assume the pin is successful for UI purposes and run monitor the pin result in a deferred async() IFFE. That way you get the UI and can just revert it, or throw it in an error tab?

> Ok this worked once but i see the error you mentioned, the issues is that we are expecting a response from the `pin` endpoint. The thing is that when that response arrives the file is already pinned so no need for the pinning UI Small files get pinned near instantly. The hang is it searching the network for the file then queing it. Realistically need to test anything over 100 MB. One thing you could do is optimistically assume the pin is successful for UI purposes and run monitor the pin result in a deferred async() IFFE. That way you get the UI and can just revert it, or throw it in an error tab?

ditorodev commented

2024-03-28 23:47:31 +00:00

done

ditorodev closed this issue

2024-03-28 23:47:31 +00:00

Sign in to join this conversation.