LumeWeb
/
p-timeout
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ensure milliseconds argument is not NaN (#25)

This commit is contained in:
Kiko Beats 2021-10-23 15:54:29 +02:00 committed by GitHub
parent 7dd311757e
commit 6b6c4e85c3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
index.js
View File

@ -8,7 +8,7 @@ export class TimeoutError extends Error {
export default function pTimeout(promise, milliseconds, fallback, options) { export default function pTimeout(promise, milliseconds, fallback, options) {
let timer; let timer;
const cancelablePromise = new Promise((resolve, reject) => { const cancelablePromise = new Promise((resolve, reject) => {
if (typeof milliseconds !== 'number' || milliseconds < 0) { if (typeof milliseconds !== 'number' || Math.sign(milliseconds) !== 1) {
throw new TypeError(`Expected \`milliseconds\` to be a positive number, got \`${milliseconds}\``); throw new TypeError(`Expected \`milliseconds\` to be a positive number, got \`${milliseconds}\``);
} }

4
test.js
View File

@ -20,6 +20,10 @@ test('throws when milliseconds is negative number', async t => {
await t.throwsAsync(pTimeout(delay(50), -1), {instanceOf: TypeError}); await t.throwsAsync(pTimeout(delay(50), -1), {instanceOf: TypeError});
}); });
test('throws when milliseconds is NaN', async t => {
await t.throwsAsync(pTimeout(delay(50), Number.NaN), {instanceOf: TypeError});
});
test('handles milliseconds being `Infinity`', async t => { test('handles milliseconds being `Infinity`', async t => {
t.is( t.is(
await pTimeout(delay(50, {value: fixture}), Number.POSITIVE_INFINITY), await pTimeout(delay(50, {value: fixture}), Number.POSITIVE_INFINITY),