fix: only block peer if we have the id, and the maps were flipped

service/p2p.go

@@ -239,17 +239,19 @@ func (p *P2PImpl) ConnectToNode(connectionUris []*url.URL, retried bool, fromPee
 			p.outgoingPeerFailures.Put(idString, counter)
 
 			if counter >= p.maxOutgoingPeerFailures {
+				if fromPeer != nil {
 					fromPeerId, err := fromPeer.Id().ToString()
 					if err != nil {
 						return err
 					}
-				p.outgoingPeerBlocklist.Put(fromPeerId, true)
-				p.incomingPeerBlockList.Put(idString, true)
+					p.incomingPeerBlockList.Put(fromPeerId, true)
 					err = fromPeer.End()
 					if err != nil {
 						return err
 					}
 				}
+				p.outgoingPeerBlocklist.Put(idString, true)
+			}
 
 			return nil
 		}