From 5aa37d4a61afb0752e76519ae7e0ef862ec1eab2 Mon Sep 17 00:00:00 2001
From: Derrick Hammer <derrick@derrickhammer.com>
Date: Thu, 13 Jul 2023 01:46:45 -0400
Subject: [PATCH] refactor: don't use un-needed for loop

---
 src/baseClient.ts | 70 +++++++++++++++++++++++------------------------
 1 file changed, 35 insertions(+), 35 deletions(-)

diff --git a/src/baseClient.ts b/src/baseClient.ts
index 34035e8..f77ba2c 100644
--- a/src/baseClient.ts
+++ b/src/baseClient.ts
@@ -5,13 +5,12 @@ import {
   getCurrentSlot,
   deserializeSyncCommittee,
 } from "@lodestar/light-client/utils";
-import { init } from "@chainsafe/bls/switchable";
+import bls, { init } from "@chainsafe/bls/switchable";
 import { Mutex } from "async-mutex";
 import { fromHexString, toHexString } from "@chainsafe/ssz";
 import { deserializePubkeys, getDefaultClientConfig } from "#util.js";
 import { capella, LightClientUpdate } from "#types.js";
-import bls from "@chainsafe/bls/switchable.js";
-import { assertValidLightClientUpdate } from "@lodestar/light-client/validation.js";
+import { assertValidLightClientUpdate } from "@lodestar/light-client/validation";
 
 export interface BaseClientOptions {
   prover: IProver;
@@ -121,43 +120,44 @@ export default abstract class BaseClient {
     currentPeriod: number,
     startCommittee: Uint8Array[],
   ): Promise<{ syncCommittee: Uint8Array[]; period: number }> {
-    for (let period = startPeriod; period < currentPeriod; period += 1) {
-      try {
-        const updates = await this.options.prover.getSyncUpdate(
-          period,
-          currentPeriod,
+    try {
+      const updates = await this.options.prover.getSyncUpdate(
+        startPeriod,
+        currentPeriod - startPeriod,
+      );
+
+      for (let i = 0; i < updates.length; i++) {
+        const curPeriod = startPeriod + i;
+        const update = updates[i];
+
+        const updatePeriod = computeSyncPeriodAtSlot(
+          update.attestedHeader.beacon.slot,
         );
 
-        for (let i = 0; i < updates.length; i++) {
-          const curPeriod = period + i;
-          const update = updates[i];
+        const validOrCommittee = await this.syncUpdateVerifyGetCommittee(
+          startCommittee,
+          curPeriod,
+          update,
+        );
 
-          const validOrCommittee = await this.syncUpdateVerifyGetCommittee(
-            startCommittee,
-            curPeriod,
-            update,
-          );
-
-          if (!(validOrCommittee as boolean)) {
-            console.log(`Found invalid update at period(${curPeriod})`);
-            return {
-              syncCommittee: startCommittee,
-              period: curPeriod,
-            };
-          }
-
-          await this.options.store.addUpdate(period, update);
-
-          startCommittee = validOrCommittee as Uint8Array[];
-          period = curPeriod;
+        if (!(validOrCommittee as boolean)) {
+          console.log(`Found invalid update at period(${curPeriod})`);
+          return {
+            syncCommittee: startCommittee,
+            period: curPeriod,
+          };
         }
-      } catch (e) {
-        console.error(`failed to fetch sync update for period(${period})`);
-        return {
-          syncCommittee: startCommittee,
-          period,
-        };
+
+        await this.options.store.addUpdate(curPeriod, update);
+
+        startCommittee = validOrCommittee as Uint8Array[];
       }
+    } catch (e) {
+      console.error(`failed to fetch sync update for period(${startPeriod})`);
+      return {
+        syncCommittee: startCommittee,
+        period: startPeriod,
+      };
     }
     return {
       syncCommittee: startCommittee,