Deepanjali Gerangal
e3a285ae54
fix #418 test for fsPromises.truncate(path[, len]) to test when length is negative
2018-12-14 19:24:19 -05:00
Petr Bouianov
1775c24d37
Fixes issue 75
...
As the array flags were already reflected in the README documentation
and example, this only required a test
2018-12-14 17:31:31 -05:00
David Humphrey
2841b2eba7
Fixes from review
2018-12-12 22:09:41 -05:00
Mera-Gangapersaud
0352dad66c
Corrected Travis CI error for issue 500
2018-12-12 22:09:41 -05:00
David Humphrey
33339b81d7
Fix review issues
2018-12-12 21:38:16 -05:00
Adam
7e941bb304
Update fs.symlink.spec.js
2018-12-12 21:38:16 -05:00
Adam
db237e617b
update fs.symlink.spec.js based on code review
...
white spaces , comments added, Promises.Open used
2018-12-12 21:38:16 -05:00
Pooch11
0a1aa0fecc
Added tests for symlink using promises api
2018-12-12 21:38:16 -05:00
David Humphrey
16e6b3e1c9
Fix review issues
2018-12-12 21:31:27 -05:00
Dragomegak
af3815c54b
Removes Symbolic Link check & Fixing Mixing Callbacks and Promises (Basically the fs.link test though)
2018-12-12 21:27:13 -05:00
Dragomegak
0748951ca8
Changed code to reflect promise syntax
2018-12-12 21:27:13 -05:00
Dragomegak
265f0b1d0d
Added fsPromises.link() tests
2018-12-12 21:27:13 -05:00
David Humphrey
1c450ae8e7
Fix review nits, move contents to earlier scope and reuse.
2018-12-12 21:08:30 -05:00
PopeSpaceous
0395c4beae
Fix issue-447: Added test to append numbers in fs.appendFile function
2018-12-12 21:08:30 -05:00
jagmeetb
1abcb0369b
Fix #431 : add test for fsPromises.unlink
...
add newline at end
implemented suggestions
formatting fixes
2018-12-12 20:59:41 -05:00
David Humphrey
d1dd5fef61
Finishing work in #401
2018-12-10 23:57:10 -05:00
Josh Mayers
e85880dc8b
Fix Issue #399 - added test cases for appendFile with promises
2018-12-10 23:57:10 -05:00
David Humphrey
5218057d80
Follow-up from #603 , rename ImportExportProvider to SerializableMemoryProvider
2018-12-05 10:18:31 -05:00
David Humphrey
61a1f5e020
Fix #603 : add import/export provider to work with JSON fs images
2018-12-04 22:54:29 -05:00
Deepanjali Gerangal
0f93a04e40
Fix for issue #561 - Extend fs.access to support R_OK, W_OK, and X_OK ( #601 )
...
* added extended test for fs.access
* making requested changes
2018-12-03 23:08:40 -05:00
David Humphrey (:humph) david.humphrey@senecacollege.ca
f5678ebe20
Rebase and rework test, skip() for now, see #594
2018-12-02 10:19:43 -05:00
kwkofler
97fb82769a
Issue #158 - Added test to ensure that watchers monitoring hardlinks are notified when the original file is updated
2018-12-02 10:19:43 -05:00
David Humphrey (:humph) david.humphrey@senecacollege.ca
7d196763f8
Update docs, fix test failure
2018-12-02 00:05:57 -05:00
kwkofler
6a5d9073f3
Issue 87 - Added fs.fsync() as a no-op, and added tests. Modified documentation.
...
Made requested changes to tests, functionality; reverted doc changes
2018-12-02 00:05:57 -05:00
David Humphrey (:humph) david.humphrey@senecacollege.ca
a107fe21d7
Fix #337 : Pick up sedge's changes from 3c49743559
2018-12-01 22:20:09 -05:00
David Humphrey (:humph) david.humphrey@senecacollege.ca
d7945d745d
Fix #577 : deal with promise exceptions and test console spam
2018-12-01 22:07:24 -05:00
David Humphrey (:humph) david.humphrey@senecacollege.ca
923b999e89
Fix #547 : update Buffer use, docs, tests to match node.js v11.3.0
2018-12-01 20:05:05 -05:00
David Humphrey (:humph) david.humphrey@senecacollege.ca
cc6e3f7edf
Increase coverage: check for non-int with chown/fchown
2018-11-29 22:47:26 -05:00
David Humphrey
43d2632069
Improve coverage: add test for rel paths with symlink
2018-11-29 16:57:06 -05:00
yatsenko-julia
f57c7330d3
fix #556 : added tests for fs.ftruncate method ( #557 )
...
* fix #556 : added tests for fs.ftruncate method
* Update fs.ftruncate.spec.js
2018-11-28 22:42:17 -05:00
David Humphrey
d1cf1286cb
Fix #576 : remove unnecessary methods from fs.promises, adjust tests to match
2018-11-28 19:42:32 -05:00
David Humphrey
2135ee17e9
Update fs.stat.spec.js to not have uncaught exception on promise
2018-11-28 19:41:46 -05:00
David Humphrey
725bfbf30c
Fixes #422 : Add nyc lcov-based code coverage for tests ( #565 )
...
* Add nyc lcov-based code coverage for tests
* Add codecov to travis
* Add codecov badge to README
2018-11-28 19:24:03 -05:00
yuzhouChen
89626107cc
Fix #568 : switch all stats.type checks in tests/ to use is*() methods ( #581 )
...
* Fix Issue#568
* Fix issue 568: two more file changes
* Fix issue 568: more changes in tests/spec/shell/ls.spec.js
2018-11-28 13:54:20 -05:00
Susan Truong
a25d71b524
Fix #435 : add a test for fsPromise.unlink() to delete a file that does not exist
...
Make changes to `fsPromises.unlink()` to be more promise-friendly
Added a newline to the end of the file
Made a change to fsPromises.unlink() to be more friendly
Changed the description of the promises test
2018-11-27 13:18:39 -05:00
Alan K
d1afe9719d
Merge pull request #476 from steaward/issue-420
...
Fixes #420
2018-11-22 01:46:52 -05:00
Deepanjali Gerangal
400b2c3c88
Fix #558 - Implementing fs.access() method ( #560 )
...
* Implementing fs.access() method
* added new line to access.js
* updated requested changes
* updated README.md with fs.access
* fixing truncate error
* updated README.md
* changed access.js to access.spec.js
2018-11-17 15:31:20 -05:00
Alexander Ponomaroff
ce030b91fa
Fix issue #398 - Add testing for promises to all test cases in fs.writeFile-readFile.spec.js file ( #402 )
...
* Fix issue #398 - Add testing for promises to all test cases in fs.writeFile-readFile.spec.js file
* Fix issue #398 - Add testing for promises to all test cases in fs.writeFile-readFile.spec.js file
* Fixed requested issues
* Further Improvement
2018-10-20 16:59:26 -04:00
Deepanjali Gerangal
5568c27bec
fix for #542 for fsPromises.symlink(target, path[, type]) ( #543 )
...
* updating fs.symlink for promises
* updated the requested changes
* fix#542 added a newline at end
2018-10-20 16:57:45 -04:00
Volodymyr Klymenko
bfcb5a6a94
Added tests for Promises version of mkdir ( #415 )
2018-10-16 19:27:12 -04:00
ThomasNolte
3bbabfcb4a
added tests for fs.promises.chown() closes #465 ( #471 )
...
* added tests for fs.promises.chown() for check if function exists and updating gid/uid for a file
* update to pass lint tests
* cleaned up code. replaced all callbacks with promises in new test.
* Revert "lint tests fix"
This reverts commit 3c256124cf
, reversing
changes made to 71a6f514fc
.
* Revert "cleaned up code. replaced all callbacks with promises in new test."
This reverts commit 71a6f514fc
.
* Made requested changes.
2018-10-16 11:43:59 -04:00
Shawn Pang
1eab5f0ffd
Fix#461 - Added test for fs.read when attempting to read a file that does not exist ( #472 )
...
* Added test for fs.read when attempting to read a file that does not exist
* Added test for fs.read when attempting to read a file that does not exist
* Modified read test for non-existent file to act more similar to earlier tests
* Added check in read test for error code
2018-10-16 11:22:54 -04:00
yatsenko-julia
73f0f19bb9
Fix #523 : added tests for fs.ftruncate() ( #524 )
...
* Fix #523 : added tests for fs.ftruncate()
* fix #523 : moved a function from truncate to ftruncate and made a few minor changes
* Fixed indentation
2018-10-16 11:21:49 -04:00
bblarney
707d404db0
Issue 417 - Added test for fs.promises.rename to rename existing directory ( #460 )
...
* test added
* working so far
* done
* cleaned up a catch
* made some requested changes
2018-10-16 11:07:10 -04:00
VictorKubrak
a447b2dd45
rename() should be able to rename an existing file to the same filename ( #502 )
...
* rename should not change name to itself
* new test expects failure
* should rename an existing file to itself
* should rename an existing file to itself
* Update tests/spec/fs.rename.spec.js
* add .skip to the test
2018-10-16 09:43:44 -04:00
AHKol
8aa8dda4d6
Fix #411 : Tests if event is thrown when calling rename ( #478 )
...
* Fix #411 : Tests if event is thrown when calling rename
* npm run lint:fix
* Added comment explaining lack of 'rename' event check
2018-10-15 16:33:47 -04:00
Stephen Ward
675773b92a
re-added the newline, as well as another test case to make sure mode is still set to default value when a new file is opened
2018-10-10 15:10:34 -04:00
Janice
41510e7da4
Fix issue 529 ( #530 )
...
* Fix issue 529
* Fix Issue 529
* Fix issue 529 and some indentations
* fix arrow function instead of function expression
* Fix issue529
* Fix issue529
* Saving files before refreshing line endings
* done
* push again
* change sth
* changed
2018-10-09 21:17:25 -04:00
Stephen Ward
7a6a4160e6
made changes as per thomas's and dave's PR review
2018-10-09 20:25:19 -04:00
pynnl
c33f22b464
Issue 396 - Add a test for fs.promises.stat() when the path does not exist ( #406 )
...
* test non exist path for promise
* fix new line at the end
* fix missing semicolon 113:26
* follow 'Testing promise codes' on guidline
2018-10-09 17:40:35 -04:00