Commit Graph

320 Commits

Author SHA1 Message Date
Stephen Truong 934ef8bfa7 Fix #419: Add test for fsPromises.open() when the path does not exist (#455)
* Fix #419: Add test for fsPromises.open() when the path does not exist

* Update package.json

* Fix #419: Add test for fsPromises.open() when the path does not exist

Removed some unnecessary code based on reviews

* Update fs.open.spec.js
2018-10-09 16:00:56 -04:00
Ruihui Yan c7ea45a18b Fix issue #475 - Add test for fs.exits() when resulting path of a symbolic link is not found (#519)
* add test for exits when resulting path of a symbolic link is not found

* fixed style nit
2018-10-09 14:31:15 -04:00
Sean 009821290f Fixes #499: Update functionality for fs.truncate (#533)
* Fixes #499: Update functionality for fs.truncate

This change to fs.truncate()'s functionality throws an error when the
length to truncate by is a non-numeric string.

* Refactor numeric type validation

As node implements a helper function to validate numeric values, let's
replicate the same logic to use throughout Filer.
2018-10-09 13:53:26 -04:00
Thanh Nguyen 2f3c384868 Add test for fsPromises.rmdir() when dir not empty and dir is a file, Fix Issue 474 (#510)
* Saving files before refreshing line endings

* Adding test case for returning an error if the path is not a directory

* Add return for fsPromises, and few other small fixes

* Fix promises, and few done parameter

* Update fs.rmdir.spec.js
2018-10-09 13:51:19 -04:00
giantpanpan beea03dbae Add test for fs.writeFile-readFile.spec to write a file in non-existing path (#486) 2018-10-09 13:48:51 -04:00
ywpark1 3e0da99040 Fix issue-426: Add the test for fsPromises.readdir when the path exists, and is a directory (#452) 2018-10-09 13:32:09 -04:00
dleung25 02bd6d8a62 Issue#518 fix: Add test for fsPromises.unlink() should be a function (#526)
* issue518 fix

* changed back to original package.json

* add newline to end of file
2018-10-09 13:27:22 -04:00
Jeffrey Espiritu 7e27c8be2c Fix Issue #400 - add test for passing file to fs.promise.readdir() (#409)
* Fix Issue #400 - add test for passing file to fs.promise.readdir()

This adds a test to ensure that `fs.promise.readdir()` throws an error when passing in a file.

* Made changes to `fsPromises.readdir` to be more promise-friendly
2018-10-09 13:04:19 -04:00
Casva e77361107e Issue 427 - Add tests to fsPromises.rmdir when directory doesn't exist and when trying to delete root directory (#457)
* Fix #427 - Fixed indentation and ENOENT -> EBUSY on line 120

* Deleted extra line at the end of document

* Fix #427 - Added tests for fsPromises.rmdir when trying to remove a nonexistent directory and when trying to remove root directory
2018-10-09 13:02:01 -04:00
Daniel Bogomazov 87230ce1e3 Fix #405 - Added tests for chmod and fchmod using Promises (#458)
* Added tests for chmod and fchmod using Promises

* Remove unrelated files from pull request

* Fixed spelling mistake

* Removed redundant catch blocks
2018-10-09 12:59:17 -04:00
Huda Al Dallal 2e2e2f9d64 Fixed issue#480 using promises to test fs.truncate when path does not exist (#516)
* added a test for issue#480 using promises to test fs.truncate

* Fixed issue#480 tesing fs.truncate using promises when path does not exist
2018-10-09 12:56:20 -04:00
rdittrich97 0354c7e13e Fix #423: added proimse support for fs.stat (#432)
* added promise support to fs.stat

* restored package lock

* fixed lint issues

* made tests more promise freindly

* removed .catch statement from promise and fixed style issues

* removed .catch statement from promise and fixed style issues
2018-10-09 12:54:40 -04:00
y2s82 1156f420c4 Fixed #424 - implement fs.promises.read tests (#429)
* implemented first two tests of fs.promises.read

* simplified the 2nd fs.promises.read test

* implemented test on file position update for fs.promises.read

* implemented directory read failure test for fs.promises.read

* implemented test to check the return type to be a Promise in fs.promises.read

* fixed indentation and also fixed a catch statement to allow all code to be reachable

* made tests more promise-friendly

* applied some style changes and test changes as per @rdittrich97 suggestions

* removed lines that are unnecessary for promise-based testing and syntactically simplified some function definitions

* removed more unnecessary check lines in directory check fail test
2018-10-09 12:51:59 -04:00
Nick Skuybeda 86b6b2a907 Fixed Issue #483 for a test done for fs.mknod promise (#509)
* test done for fs.mknod promise

* fixing whitespaces
2018-10-09 12:43:45 -04:00
Chaya Danzinger a8759b1e38 Add tests for fs.promises utimes function #527 (#540)
* first two promise tests initial commit

* implemented existing tests but with promises

* add final tests

* add return statement for remaining tests

* fix function call error
2018-10-09 12:39:18 -04:00
Stephen Ward 30752c9109 added a test: open a new file for writing, and set a mode for that file 2018-09-24 23:28:56 -04:00
Stephen Ward 78b3452d5d added the addition of an optional mode when opening a file, removed my test because it was broken. Seemingly passes all the other tests still. STILL TO DO: add a proper test which makes sure the mode is set. 2018-09-24 19:10:09 -04:00
Stephen Ward e7811eb53b fixed lint spaces/indentation errors 2018-09-24 17:46:01 -04:00
Stephen Ward add00ce563 testing out the validateAndMask() function, with console.log's... 2018-09-23 13:49:00 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca 5e4de6b698 Fix #393: add test for truncate with length undefined 2018-09-17 18:30:09 -04:00
David Humphrey 0980ec4608 Fix lint issues in issue258.js 2018-07-27 11:09:45 -04:00
David Humphrey a31044cc8d Fix lint issues in issue267.js 2018-07-27 11:08:40 -04:00
David Humphrey 454d5bc801 Fix lint issues in ls-depth-bug.js 2018-07-27 11:07:17 -04:00
David Humphrey d41885e9d0 Fix lint issue in tests/lib/indexeddb.js 2018-07-27 11:03:43 -04:00
David Humphrey 0e00af661a Fix lint issues in fs.appendFile.spec.js 2018-07-27 11:02:42 -04:00
David Humphrey f89b616fdc Fix issues in fs.chmod.spec.js 2018-07-27 11:01:47 -04:00
David Humphrey cbcddee3be Fix lint issues in fs.chown.spec.js 2018-07-27 11:01:26 -04:00
David Humphrey 1a738dd2bb Fix lint issues in fs.close.spec.js, fs.link.spec.js 2018-07-27 11:00:48 -04:00
David Humphrey 9e08d96c96 Fix lint issues in fs.lstat.spec.js 2018-07-27 10:44:42 -04:00
David Humphrey 980d5d0917 Fix lint issues in fs.lseek.spec.js 2018-07-27 10:43:51 -04:00
David Humphrey a8e373e4b9 Fix lint issues in fs.mknod.spec.js 2018-07-27 10:39:34 -04:00
David Humphrey 86e57d60db Fix lint issues in fs.open.spec.js 2018-07-27 10:38:44 -04:00
David Humphrey 054094c852 Fix lint issues in fs.read.spec.js, fix test failure in fs.stats.spec.js 2018-07-27 10:37:45 -04:00
David Humphrey cafff52c3a Fix lint issues in fs.rename.spec.js 2018-07-27 10:34:21 -04:00
David Humphrey 1c7b40c895 Fix lint issues in fs.stats.spec.js 2018-07-26 18:17:05 -04:00
David Humphrey 7258a2913e Fix lint issues in fs.truncate.spec.js 2018-07-26 18:07:50 -04:00
David Humphrey bb8743eda1 Fix lint issues in fs.unlink.spec.js 2018-07-26 18:02:16 -04:00
David Humphrey 94e6a98cb8 Fix lint issues in fs.utimes.spec.js 2018-07-26 18:01:21 -04:00
David Humphrey ee8e2a665a Fix lint issues in fs.writeFile-readFile.spec.js 2018-07-26 18:01:07 -04:00
David Humphrey a93ae13c99 Fix lint issues in fs.xattr.spec.js 2018-07-26 17:56:54 -04:00
David Humphrey ab87c7f14a Fix lint issues in tests-fs-watch.js 2018-07-26 17:54:26 -04:00
David Humphrey 49931722cc Fix lint issues in path-resolution.spec.js 2018-07-26 17:53:02 -04:00
David Humphrey 3e1c3deb51 Fix lint issues in providers.base.js 2018-07-26 17:50:32 -04:00
David Humphrey a8c3fa85db Fix lint issues in exec.spec.js 2018-07-26 17:44:27 -04:00
David Humphrey 51c81edb5b Fix lint issues in touch.spec.js 2018-07-26 17:41:35 -04:00
David Humphrey 8e900a3a88 Fix lint issues in time-flags.spec.js 2018-07-26 17:39:19 -04:00
David Humphrey 4a066064f4 Fix lint issues in times.spec.js 2018-07-26 17:37:26 -04:00
David Humphrey a900d8df6d Add eslint --fix scripts, fix first round of lint errors 2018-07-15 13:25:35 -04:00
David Humphrey 9832807dd1 Rebase and update to changes on develop 2018-07-14 11:21:34 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca 65bbc17ccb Update package.json + tests/ to support browser property for bundlers, delete old useless tests for AMD 2018-07-14 10:53:23 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca d61c61aab8 Switch to parceljs for bundling, eslint for linting, drop grunt 2018-07-14 10:50:22 -04:00
David Humphrey b7ecae4af1 Fix typos and clean up for review 2018-07-14 10:02:29 -04:00
David Humphrey 4e73ef8d9b Allow relpaths for symlink targets (needed by P9vfs), get rid of path info in Node 2018-07-14 10:02:29 -04:00
David Humphrey 9508833b37 Add chown, fchown, chmod, fchmod and tests. 2018-07-14 10:02:29 -04:00
David Humphrey bf1d0e41d6 Fix bug with stats.name generated from fd, add tests 2018-07-14 10:02:29 -04:00
David Humphrey c526445a43 Fix mode, fs.link, fix other bugs and cleanup 2018-07-14 10:02:29 -04:00
David Humphrey 0aaaeacd1a Update sh.ls and stats to remove bits I don't need, add what I do. 2018-07-14 10:02:29 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca 3650b798ed Use transaction per operation in indexeddb.js, fix broken async tests in fs.stats.spec.js
Fixing for review comments

Switch to RW or RO transaction per get/put/delete/clear, better error handling for try/catch cases

Switch back to transaction-per-context for better atomic fs operations.

Move _getObjectStore onto prototype
2017-05-25 10:04:20 -04:00
Alan K 525e11f203 Suppress console.error message in test case 2015-08-16 13:18:26 -04:00
Alan K ddc41f49a5 Fixed default provider when no query string is passed 2015-08-16 13:14:31 -04:00
Alan K 8325b5a9d7 Add a new 'default' provider option so we can force the memory provider
for testing
2015-08-16 13:02:39 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca c85fa1851f Fix #357 - Path.resolve() should not crash with missing Path.relative() 2015-06-29 11:38:51 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca 17fb8993c3 fs.rename() should normalize paths before using, dir vs. dir/ 2015-05-12 15:16:32 -04:00
Gideon Thomas e9c4cb6d7a Fix #340 - Set provider type for unit tests in the browser 2015-03-30 10:30:50 -04:00
Gideon Thomas 8c4de99a98 Fix #334 - Do not allow fs.link on directories 2014-12-17 13:30:31 -05:00
gideonthomas d28100c422 Fix #308 - fs.rename does not work on directories 2014-12-06 16:34:36 -05:00
Alan K d6c77abfa0 Merge pull request #331 from humphd/issue329
Fix #329 - Implement Shell.find()
2014-12-02 11:23:43 -05:00
David Humphrey (:humph) david.humphrey@senecacollege.ca 21b602ef66 Fix #329 - Implement Shell.find() 2014-11-28 15:05:47 -05:00
David Humphrey (:humph) david.humphrey@senecacollege.ca 4cdcca1a8d Ensure test providers deal with missing callback early 2014-11-27 10:31:49 -05:00
Gideon Thomas 91f7bf0319 Fix #256 - fs.read() for dir paths should fail 2014-11-16 00:12:53 -05:00
Kieran Sedgwick 0d4110ff6f Fixed #323 - Updated references to "fs.Shell" in the docs and test suite 2014-11-14 12:04:51 -05:00
Kieran Sedgwick a05faf0b2a Review fixes 2014-11-06 10:31:45 -05:00
Kieran Sedgwick 3178ad9a45 Review fixes 2014-11-04 13:03:49 -05:00
Kieran Sedgwick c4c13c1535 Fix #245 - Forced the user to manually instantiate FileSystemShell objects 2014-11-04 13:03:49 -05:00
David Humphrey (:humph) david.humphrey@senecacollege.ca f9e21cd576 Add note about https://github.com/filerjs/filer/issues/314 2014-10-17 13:34:29 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca 1a4be5e2fd Add test for deleted node accessed via ofd 2014-10-17 13:16:09 -04:00
Ali Al Dallal a37f262f41 Make it possible to run the test 2014-09-30 14:47:13 -04:00
gideonthomas 8c00b856bc Fix #294 - Failure to unlink directories should return an EPERM error 2014-09-24 11:22:29 -04:00
gideonthomas 19eea4f502 Fix #288 - fs.unlink should fail on directory nodes 2014-09-22 11:16:02 -04:00
Ali Al Dallal 5a75de1881 Fix bower can't run in some OS 2014-09-12 15:03:29 -04:00
Ali Al Dallal adf039943d Remove wget to make Filer work in node.js 2014-09-09 09:30:03 -04:00
Alan K 4126321996 remove zip/unzip from shell 2014-09-02 15:48:54 -04:00
gideonthomas f451ed96cc Fix #270 and #276 - pathCheck should handle undefined paths and fix INAVL typo 2014-08-21 16:14:57 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca ba5f3fdbcd Fix #266 - let FileSystem ctor figure out if an existing filesystem exists 2014-08-20 20:53:01 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca 4bba2512b0 Failing test for #267, readdir on file path should error 2014-08-20 15:44:12 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca fe0d6ce680 Comment out unused errors for space saving on filer.js 2014-08-18 21:31:25 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca 851d863652 A few fixes 2014-08-18 19:21:35 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca ee9ea82cfb Fix #261 - include path in errors 2014-08-18 19:13:50 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca 84112410ba Fix #258 - Queued fs calls hang when fs goes into error state due to provider.open error 2014-08-18 14:08:54 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca 1a2774b152 ack's fix + more tests for various cases 2014-08-17 17:15:00 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca b3da2f7681 Fix file name 2014-08-17 15:21:16 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca c916c0a407 Update tests/index.js to run regression 2014-08-17 15:12:44 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca 76118694bf Failing test 2014-08-17 15:12:08 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca d44b37c13d Add test for zero-length buffers with getBuffer/putBuffer 2014-08-16 17:07:38 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca d55bf23f1b Initial work on #227 - improve storage efficiency of provider API 2014-08-16 16:22:41 -04:00
secretrobotron 77e0ee7117 [issue249] fixed Buffer prototype & tests 2014-08-09 13:05:15 -04:00
secretrobotron af1943b5c9 [Issue249] Support for ArrayBuffer in Filer.Buffer
1. Added proxy Buffer constructor for Filer.Buffer.
2. Added tests for new Filer.Buffer.
2014-08-08 15:18:09 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca 5b785037f0 Fix #247 - sh.cwd() not updating cwd on success, with test. 2014-07-28 18:14:59 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca e063edc6fc Expanded test for wide dirs, fix, switch to async.eachSeries everywhere 2014-07-21 15:08:39 -04:00
David Humphrey (:humph) david.humphrey@senecacollege.ca 064e986d26 sh.ls() fails when stack sized is reached for deep recursive listings: RangeError: Maximum call stack size exceeded 2014-07-21 13:17:16 -04:00