From ee5679460183df83e15df1f094ef8ac06850c23f Mon Sep 17 00:00:00 2001 From: Charles M Drani Date: Wed, 27 Feb 2019 09:56:11 -0700 Subject: [PATCH] add test for fs.open with wx flag for existing file (#745) * add test for fs.open with wx flag for existing file * update implementation and open spec to throw EEXIST --- src/filesystem/implementation.js | 2 +- tests/spec/fs.open.spec.js | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/src/filesystem/implementation.js b/src/filesystem/implementation.js index 725097b..b5a8f8b 100644 --- a/src/filesystem/implementation.js +++ b/src/filesystem/implementation.js @@ -620,7 +620,7 @@ function open_file(context, path, flags, mode, callback) { directoryData = result; if(directoryData.hasOwnProperty(name)) { if(flags.includes(O_EXCLUSIVE)) { - callback(new Errors.ENOENT('O_CREATE and O_EXCLUSIVE are set, and the named file exists', path)); + callback(new Errors.EEXIST('O_CREATE and O_EXCLUSIVE are set, and the named file exists', path)); } else { directoryEntry = directoryData[name]; if(directoryEntry.type === NODE_TYPE_DIRECTORY && flags.includes(O_WRITE)) { diff --git a/tests/spec/fs.open.spec.js b/tests/spec/fs.open.spec.js index edb7bc8..819b1ba 100644 --- a/tests/spec/fs.open.spec.js +++ b/tests/spec/fs.open.spec.js @@ -47,6 +47,23 @@ describe('fs.open', function() { }); }); + it('should return an error when flagged for write and the path exists', function(done) { + var fs = util.fs(); + + fs.mkdir('/tmp', function(error) { + if(error) throw error; + fs.writeFile('/tmp/file', 'data', function(error) { + if(error) throw error; + fs.open('/tmp/file', 'wx', function(error, result) { + expect(error).to.exist; + expect(error.code).to.equal('EEXIST'); + expect(result).not.to.exist; + done(); + }); + }); + }); + }); + it('should return an error when flagged for append and the path is a directory', function(done) { var fs = util.fs();