diff --git a/src/filesystem/implementation.js b/src/filesystem/implementation.js index 35e4abe..1ec08ea 100644 --- a/src/filesystem/implementation.js +++ b/src/filesystem/implementation.js @@ -1623,15 +1623,15 @@ function open(fs, context, path, flags, mode, callback) { * callback = makeCallback(callback); * } */ - if (arguments.length == 5){ - callback = arguments[arguments.length - 1]; - } - else { - //need to test this validateAndMakeMode - console.log("open'd mode: " + mode) - mode = validateAndMaskMode(mode, FULL_READ_WRITE_EXEC_PERMISSIONS, callback); - console.log("mask'd mode: " + mode) - } + if (arguments.length == 5){ + callback = arguments[arguments.length - 1]; + } + else { + //need to test this validateAndMakeMode + console.log('open\'d mode: ' + mode); + mode = validateAndMaskMode(mode, FULL_READ_WRITE_EXEC_PERMISSIONS, callback); + console.log('mask\'d mode: ' + mode); + } if(!pathCheck(path, callback)) return; @@ -1921,7 +1921,7 @@ function isUint32(value) { // Validator for mode_t (the S_* constants). Valid numbers or octal strings // will be masked with 0o777 to be consistent with the behavior in POSIX APIs. function validateAndMaskMode(value, def, callback) { - console.log("Passed in mode: " + value) + console.log('Passed in mode: ' + value); if(typeof def === 'function') { callback = def; def = undefined; @@ -1929,7 +1929,7 @@ function validateAndMaskMode(value, def, callback) { if (isUint32(value)) { let newMode = value & FULL_READ_WRITE_EXEC_PERMISSIONS; - console.log("Masked mode: " + newMode) + console.log('Masked mode: ' + newMode); return value & FULL_READ_WRITE_EXEC_PERMISSIONS; } @@ -1950,7 +1950,7 @@ function validateAndMaskMode(value, def, callback) { return false; } var parsed = parseInt(value, 8); - console.log("Parsed + Masekd mode: " + parsed & FULL_READ_WRITE_EXEC_PERMISSIONS) + console.log('Parsed + Masekd mode: ' + parsed & FULL_READ_WRITE_EXEC_PERMISSIONS); return parsed & FULL_READ_WRITE_EXEC_PERMISSIONS; } diff --git a/tests/spec/fs.open.spec.js b/tests/spec/fs.open.spec.js index ce7435d..64caf0d 100644 --- a/tests/spec/fs.open.spec.js +++ b/tests/spec/fs.open.spec.js @@ -117,7 +117,7 @@ describe('fs.open', function() { expect(result).to.exist; expect(result.type).to.equal('FILE'); expect(result.mode).to.exist; - expect(result.mode).to.equal(33188) + expect(result.mode).to.equal(33188); done(); }); });