LumeWeb
/
filer
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #173 from pbouianov/issue78 

Tests that expect errors check error codes. Fixes issue78
This commit is contained in:
Alan K 2014-04-20 11:06:19 -04:00
parent 9c11fe562c febba4c8ba
commit badc309297
17 changed files with 34 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/shell/shell.js
View File

@ -154,7 +154,7 @@ define(function(require) {
callback = callback || function(){};
if(!files) {
callback(new Error("Missing files argument"));
callback(new Errors.EINVAL("Missing files argument"));
return;
}
@ -208,7 +208,7 @@ define(function(require) {
callback = callback || function(){};
if(!dir) {
callback(new Error("Missing dir argument"));
callback(new Errors.EINVAL("Missing dir argument"));
return;
}
@ -280,7 +280,7 @@ define(function(require) {
callback = callback || function(){};
if(!path) {
callback(new Error("Missing path argument"));
callback(new Errors.EINVAL("Missing path argument"));
return;
}

1
tests/spec/fs.lstat.spec.js
View File

@ -15,6 +15,7 @@ define(["Filer", "util"], function(Filer, util) {
fs.lstat('/tmp', function(error, result) {
expect(error).to.exist;
expect(error.code).to.equal("ENOENT");
expect(result).not.to.exist;
done();
});

2
tests/spec/fs.mkdir.spec.js
View File

@ -14,6 +14,7 @@ define(["Filer", "util"], function(Filer, util) {
fs.mkdir('/tmp/mydir', function(error) {
expect(error).to.exist;
expect(error.code).to.equal("ENOENT");
done();
});
});
@ -23,6 +24,7 @@ define(["Filer", "util"], function(Filer, util) {
fs.mkdir('/', function(error) {
expect(error).to.exist;
expect(error.code).to.equal("EEXIST");
done();
});
});

4
tests/spec/fs.open.spec.js
View File

@ -14,6 +14,7 @@ define(["Filer", "util"], function(Filer, util) {
fs.open('/tmp/myfile', 'w+', function(error, result) {
expect(error).to.exist;
expect(error.code).to.equal("ENOENT");
expect(result).not.to.exist;
done();
});
@ -24,6 +25,7 @@ define(["Filer", "util"], function(Filer, util) {
fs.open('/myfile', 'r+', function(error, result) {
expect(error).to.exist;
expect(error.code).to.equal("ENOENT");
expect(result).not.to.exist;
done();
});
@ -37,6 +39,7 @@ define(["Filer", "util"], function(Filer, util) {
if(error) throw error;
fs.open('/tmp', 'w', function(error, result) {
expect(error).to.exist;
expect(error.code).to.equal("EISDIR");
expect(result).not.to.exist;
done();
});
@ -50,6 +53,7 @@ define(["Filer", "util"], function(Filer, util) {
if(error) throw error;
fs.open('/tmp', 'a', function(error, result) {
expect(error).to.exist;
expect(error.code).to.equal("EISDIR");
expect(result).not.to.exist;
done();
});

1
tests/spec/fs.readdir.spec.js
View File

@ -14,6 +14,7 @@ define(["Filer", "util"], function(Filer, util) {
fs.readdir('/tmp/mydir', function(error, files) {
expect(error).to.exist;
expect(error.code).to.equal("ENOENT");
expect(files).not.to.exist;
done();
});

2
tests/spec/fs.readlink.spec.js
View File

@ -14,6 +14,7 @@ define(["Filer", "util"], function(Filer, util) {
fs.readlink('/tmp/mydir', function(error) {
expect(error).to.exist;
expect(error.code).to.equal("ENOENT");
done();
});
});
@ -23,6 +24,7 @@ define(["Filer", "util"], function(Filer, util) {
fs.readlink('/', function(error) {
expect(error).to.exist;
expect(error.code).to.equal("ENOENT");
done();
});
});

5
tests/spec/fs.rmdir.spec.js
View File

@ -14,6 +14,7 @@ define(["Filer", "util"], function(Filer, util) {
fs.rmdir('/tmp/mydir', function(error) {
expect(error).to.exist;
expect(error.code).to.equal("ENOENT");
done();
});
});
@ -23,6 +24,7 @@ define(["Filer", "util"], function(Filer, util) {
fs.rmdir('/', function(error) {
expect(error).to.exist;
expect(error.code).to.equal("EBUSY");
done();
});
});
@ -36,6 +38,7 @@ define(["Filer", "util"], function(Filer, util) {
if(error) throw error;
fs.rmdir('/', function(error) {
expect(error).to.exist;
expect(error.code).to.equal("EBUSY");
done();
});
});
@ -53,6 +56,7 @@ define(["Filer", "util"], function(Filer, util) {
if(error) throw error;
fs.rmdir('/tmp/myfile', function(error) {
expect(error).to.exist;
expect(error.code).to.equal("ENOTDIR");
done();
});
});
@ -69,6 +73,7 @@ define(["Filer", "util"], function(Filer, util) {
if(error) throw error;
fs.rmdir('/tmp/myfile', function (error) {
expect(error).to.exist;
expect(error.code).to.equal("ENOTDIR");
done();
});
});

1
tests/spec/fs.stat.spec.js
View File

@ -14,6 +14,7 @@ define(["Filer", "util"], function(Filer, util) {
fs.stat('/tmp', function(error, result) {
expect(error).to.exist;
expect(error.code).to.equal("ENOENT");
expect(result).not.to.exist;
done();
});

2
tests/spec/fs.symlink.spec.js
View File

@ -14,6 +14,7 @@ define(["Filer", "util"], function(Filer, util) {
fs.symlink('/', '/tmp/mydir', function(error) {
expect(error).to.exist;
expect(error.code).to.equal("ENOENT");
done();
});
});
@ -23,6 +24,7 @@ define(["Filer", "util"], function(Filer, util) {
fs.symlink('/tmp', '/', function(error) {
expect(error).to.exist;
expect(error.code).to.equal("EEXIST");
done();
});
});

2
tests/spec/fs.truncate.spec.js
View File

@ -18,6 +18,7 @@ define(["Filer", "util"], function(Filer, util) {
fs.truncate('/myfile', -1, function(error) {
expect(error).to.exist;
expect(error.code).to.equal("EINVAL");
done();
});
});
@ -28,6 +29,7 @@ define(["Filer", "util"], function(Filer, util) {
fs.truncate('/', 0, function(error) {
expect(error).to.exist;
expect(error.code).to.equal("EISDIR");
done();
});
});

1
tests/spec/fs.writeFile-readFile.spec.js
View File

@ -16,6 +16,7 @@ define(["Filer", "util"], function(Filer, util) {
fs.readFile('/no-such-file', 'utf8', function(error, data) {
expect(error).to.exist;
expect(error.code).to.equal("ENOENT");
expect(data).not.to.exist;
done();
});

2
tests/spec/path-resolution.spec.js
View File

@ -119,6 +119,7 @@ define(["Filer", "util"], function(Filer, util) {
fs.stat('/myfilelink1', function(error, result) {
expect(error).to.exist;
expect(error.code).to.equal("ENOENT");
expect(result).not.to.exist;
done();
});
@ -209,6 +210,7 @@ define(["Filer", "util"], function(Filer, util) {
fs.stat('/mynotdirlink/myfile', function(error, result) {
expect(error).to.exist;
expect(error.code).to.equal("ENOTDIR");
expect(result).not.to.exist;
done();
});

2
tests/spec/shell/cat.spec.js
View File

@ -15,6 +15,7 @@ define(["Filer", "util"], function(Filer, util) {
shell.cat(null, function(error, data) {
expect(error).to.exist;
expect(error.code).to.equal("EINVAL");
expect(data).not.to.exist;
done();
});
@ -71,6 +72,7 @@ define(["Filer", "util"], function(Filer, util) {
shell.cat(['/file', '/nofile'], function(err, data) {
expect(err).to.exist;
expect(err.code).to.equal("ENOENT");
expect(data).not.to.exist;
done();
});

1
tests/spec/shell/env.spec.js
View File

@ -36,6 +36,7 @@ define(["Filer", "util"], function(Filer, util) {
shell.cat(null, function(error, list) {
expect(error).to.exist;
expect(error.code).to.equal("EINVAL");
expect(list).not.to.exist;
done();
});

1
tests/spec/shell/ls.spec.js
View File

@ -15,6 +15,7 @@ define(["Filer", "util"], function(Filer, util) {
shell.cat(null, function(error, list) {
expect(error).to.exist;
expect(error.code).to.equal("EINVAL");
expect(list).not.to.exist;
done();
});

6
tests/spec/shell/mkdirp.spec.js
View File

@ -87,9 +87,9 @@ define(["Filer", "util"], function(Filer, util) {
fs.writeFile('/test.txt', 'test', function(err){
expect(err).to.not.exist;
shell.mkdirp('/test.txt/test', function(err) {
expect(err).to.exist;
expect(err.code).to.equal('ENOTDIR');
done();
expect(err).to.exist;
expect(err.code).to.equal('ENOTDIR');
done();
});
});
});

1
tests/spec/shell/rm.spec.js
View File

@ -15,6 +15,7 @@ define(["Filer", "util"], function(Filer, util) {
shell.rm(null, function(error, list) {
expect(error).to.exist;
expect(error.code).to.equal("EINVAL");
expect(list).not.to.exist;
done();
});