From 6b2a023deac21fe6d05f6fc2229a5cf444a52f42 Mon Sep 17 00:00:00 2001 From: yoavgurevich Date: Wed, 14 May 2014 16:02:46 -0400 Subject: [PATCH] Corrected conflicting syntax and added testing clause for file descriptor argument value --- src/filesystem/interface.js | 2 +- tests/spec/fs.open.spec.js | 21 ++++++++++++++++++++- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/src/filesystem/interface.js b/src/filesystem/interface.js index 175dab5..a2ad302 100644 --- a/src/filesystem/interface.js +++ b/src/filesystem/interface.js @@ -82,7 +82,7 @@ define(function(require) { fs.stdin = STDIN; fs.stdout = STDOUT; fs.stderr = STDERR; - fs.firstFD = FD; + fs.firstFD = FIRST_DESCRIPTOR; // Safely expose the list of open files and file // descriptor management functions diff --git a/tests/spec/fs.open.spec.js b/tests/spec/fs.open.spec.js index 5e05661..a0cfcb3 100644 --- a/tests/spec/fs.open.spec.js +++ b/tests/spec/fs.open.spec.js @@ -58,7 +58,7 @@ define(["Filer", "util"], function(Filer, util) { it('should return a unique file descriptor', function(done) { var fs = util.fs(); - var fd1 + var fd1; fs.open('/file1', 'w+', function(error, fd) { if(error) throw error; @@ -75,6 +75,25 @@ define(["Filer", "util"], function(Filer, util) { }); }); + it('should return the argument value of the file descriptor index matching the value set by the first useable file descriptor constant', function(done) { + var fs = util.fs(); + var openFileDescription = require('src/open-file-description'); + fs.firstFD = require('src/constants').FIRST_DESCRIPTOR; + var fd1; + + fs.open('/file1', 'w+', function(error, fd) { + if(error) throw error; + expect(error).not.to.exist; + expect(fd).to.be.a('number'); + expect(fd).not.to.equal(fd1); + + this.allocDescriptor = function(openFileDescription) { + expect(fd).to.equal(fs.firstFD); + }; + done(); + }); + }); + it('should create a new file when flagged for write', function(done) { var fs = util.fs();