LumeWeb
/
filer
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix descriptor leaks in writeFile and appendFile

This commit is contained in:
David Humphrey (:humph) david.humphrey@senecacollege.ca 2014-08-18 11:15:48 -04:00
parent 14a469510f
commit 4b1f95c6c9
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/filesystem/implementation.js
View File

@ -1785,11 +1785,13 @@ function writeFile(fs, context, path, data, options, callback) {
var ofd = new OpenFileDescription(path, fileNode.id, flags, 0); var ofd = new OpenFileDescription(path, fileNode.id, flags, 0);
var fd = fs.allocDescriptor(ofd); var fd = fs.allocDescriptor(ofd);
replace_data(context, ofd, data, 0, data.length, function(err2, nbytes) { replace_data(context, ofd, data, 0, data.length, function(err, nbytes) {
if(err2) {
return callback(err2);
}
fs.releaseDescriptor(fd); fs.releaseDescriptor(fd);
ofd = null;
if(err) {
return callback(err);
}
callback(null); callback(null);
}); });
}); });
@ -1821,11 +1823,13 @@ function appendFile(fs, context, path, data, options, callback) {
var ofd = new OpenFileDescription(path, fileNode.id, flags, fileNode.size); var ofd = new OpenFileDescription(path, fileNode.id, flags, fileNode.size);
var fd = fs.allocDescriptor(ofd); var fd = fs.allocDescriptor(ofd);
write_data(context, ofd, data, 0, data.length, ofd.position, function(err2, nbytes) { write_data(context, ofd, data, 0, data.length, ofd.position, function(err, nbytes) {
if(err2) {
return callback(err2);
}
fs.releaseDescriptor(fd); fs.releaseDescriptor(fd);
ofd = null;
if(err) {
return callback(err);
}
callback(null); callback(null);
}); });
}); });