Fix review nits, move contents to earlier scope and reuse.

This commit is contained in:
David Humphrey 2018-12-12 21:08:25 -05:00
parent 0395c4beae
commit 1c450ae8e7
1 changed files with 4 additions and 7 deletions

View File

@ -2,10 +2,12 @@ var util = require('../lib/test-utils.js');
var expect = require('chai').expect; var expect = require('chai').expect;
describe('fs.appendFile', function() { describe('fs.appendFile', function() {
const contents = 'This is a file.';
beforeEach(function(done) { beforeEach(function(done) {
util.setup(function() { util.setup(function() {
var fs = util.fs(); var fs = util.fs();
fs.writeFile('/myfile', 'This is a file.', { encoding: 'utf8' }, function(error) { fs.writeFile('/myfile', contents, function(error) {
if(error) throw error; if(error) throw error;
done(); done();
}); });
@ -20,7 +22,6 @@ describe('fs.appendFile', function() {
it('should append a utf8 file without specifying utf8 in appendFile', function(done) { it('should append a utf8 file without specifying utf8 in appendFile', function(done) {
var fs = util.fs(); var fs = util.fs();
var contents = 'This is a file.';
var more = ' Appended.'; var more = ' Appended.';
fs.appendFile('/myfile', more, function(error) { fs.appendFile('/myfile', more, function(error) {
@ -36,7 +37,6 @@ describe('fs.appendFile', function() {
it('should append a utf8 file with "utf8" option to appendFile', function(done) { it('should append a utf8 file with "utf8" option to appendFile', function(done) {
var fs = util.fs(); var fs = util.fs();
var contents = 'This is a file.';
var more = ' Appended.'; var more = ' Appended.';
fs.appendFile('/myfile', more, 'utf8', function(error) { fs.appendFile('/myfile', more, 'utf8', function(error) {
@ -52,7 +52,6 @@ describe('fs.appendFile', function() {
it('should append a utf8 file with {encoding: "utf8"} option to appendFile', function(done) { it('should append a utf8 file with {encoding: "utf8"} option to appendFile', function(done) {
var fs = util.fs(); var fs = util.fs();
var contents = 'This is a file.';
var more = ' Appended.'; var more = ' Appended.';
fs.appendFile('/myfile', more, { encoding: 'utf8' }, function(error) { fs.appendFile('/myfile', more, { encoding: 'utf8' }, function(error) {
@ -112,7 +111,6 @@ describe('fs.appendFile', function() {
it('should work when file does not exist, and create the file', function(done) { it('should work when file does not exist, and create the file', function(done) {
var fs = util.fs(); var fs = util.fs();
var contents = 'This is a file.';
fs.appendFile('/newfile', contents, { encoding: 'utf8' }, function(error) { fs.appendFile('/newfile', contents, { encoding: 'utf8' }, function(error) {
expect(error).not.to.exist; expect(error).not.to.exist;
@ -125,9 +123,8 @@ describe('fs.appendFile', function() {
}); });
}); });
it('should accept numbers and appends them to the file', function(done) { it('should accept numbers and append them to the file', function(done) {
var fs = util.fs(); var fs = util.fs();
var contents = 'This is a file.';
var more = 10000; var more = 10000;
fs.appendFile('/myfile', more, 'utf8', function(error) { fs.appendFile('/myfile', more, 'utf8', function(error) {