* fix(core): set GethInstance p2p_port in spawn
* previously, spawning Geth with disabled discovery would not actually
set the p2p port in the returned GethInstance. This is because it
would only pass the port to the geth command. If the value started as
None, it would remain to be None in the GethInstance even though a
port was passed to the command.
* adds tests for the existence of ports in GethInstance
* remove rpc port test
* rpc port test doesn't make sense because it will always be set, it is
not an Option
* use sigterm instead of sigkill
* use sigint instead of sigterm
* run tests in different directories
* prevents flaky behavior because cargo runs tests in parallel, if the
default directory were used, each GethInstance would fight for geth's
file system lock.
* remove nix as a dep
* sigkill works for now
* Updated the middleware README heading
* fix docs CI
* Added heading description for the main middlewares
* Restructure README examples
* Fix docs CI
* Fix MiddlewareBuilder function docs
* Typos inside the middleware README
Co-authored-by: Andrea Simeoni <>
* if geth is in non-dev mode, it has been explicitly set by either
disabling discovery or setting a p2p port. To prevent geth from
crashing if another process is using the default p2p port, always set
the p2p port if geth is in non-dev mode.
* On Ws error close all active subscriptions and force clients to reconnect. the Websocket.
* Comment typos
* Unit tests
Lint
cargo +nightly fmt
* - Added CHANGELOG entry
- Added `#` prefix to issue IDs where missing
* ownership typo
Co-authored-by: Andrea Simeoni <>
* tell Geth to expose the admin namespace
* wip: add admin namespace support
* add networking and peer related structs
* add rest of chain config fields
* add datadir to geth
* fix data dir ref
* add dev flag to geth
* set dev only if block_time is not set
* put mutually exclusive options in an enum
* make block_time use the devmode enum
* add p2p port to geth
* add basic impls for admin endpoints
* move from_int_or_hex to ethers-core utils
* fix nodeinfo protocol field
* the type is better represented by a struct which can have either eth
or snap
* add chain id and discovery toggle for Geth
* remove PeerEvent
* should re-add when peer event endpoints are implemented
* simplify serde options for admin responses
* change signature for peer modification apis
* these admin apis accept an enode, which _may_ be an enr, but could
also be a legacy enode "v4" url.
* add note on where `ChainConfig` fields come from
* add note on PeerInfo about the source of fields
* add admin namespace support to CHANGELOG
* update pr number in changelog
* cargo fmt
* move chainconfig to genesis in utils
* accept genesis file in geth
* add genesis writing to geth spawn
* finally get geth nodes to connect
* import io::Read in provider tests
* fix PeerInfo and use enode id for provider test
* make clippy happy
* improve documentation for genesis module
* remove not(wasm) attributes on genesis module
* remove debugging printlns
* remove io::Read from provider tests
* add failing post merge test case
* add full mainnet nodeinfo for testing
* support deserializing json bignums to U256
* the serde_json arbitrary_precision feature is necessary so the
serde_json::Number variant of `IntOrHexOrBigNum` can be converted
into a string and fed into U256::from_dec_string
* fix from_int_or_hex_opt doc string
* remove third variant from IntOrHex
* unnecessary since serde_json::Number handles smaller ints as well
* add comments for ids
* fix enode id type in admin_peers provider test
* fix admin typo in Cargo.toml
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
* add method to wait on a gethinstance adding a peer
* fix dial loop and wait_to_add_peer doc comments
* update geth
* the build can be updated by changing the GETH_BUILD env var
* wait for geth to exit on drop
* remove unnecessary wait
* fix mid-handshake PeerInfo deserialization
* remove println
* make tests less flaky
* handle discovery with the rest of the non dev opts
* dump geth stderr to debug failing ci test
* add method which dumps the unread stderr of the geth instance into a
string
* remove call_raw debug println
* bug is due to authrpc endpoint being in use
* use unused port when authrpc port is not specified
* remove dump_stderr from GethInstance
* did not work properly anyways
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
* Fixes#1899
* replace match with if let some() else
* fix error: number too large to fit in target type
* Apply suggestions from code review
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
dependabot[bot]
Andrea Simeoni
Dan Cline
joshieDo
Matthias Seitz
christn
Jared Tokuz
MouseLess.eth
odysseas.eth
James Prestwich
DaniPopes
Georgios Konstantopoulos