chore(solc): add more cache traces (#2248)

* chore(solc): add more cache traces

* simplify bools
This commit is contained in:
Matthias Seitz 2023-03-13 20:43:53 +01:00 committed by GitHub
parent 862d923f2a
commit d073930fa3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 4 deletions

View File

@ -922,7 +922,10 @@ impl<'a, T: ArtifactOutput> ArtifactsCache<'a, T> {
write_to_disk: bool, write_to_disk: bool,
) -> Result<Artifacts<T::Artifact>> { ) -> Result<Artifacts<T::Artifact>> {
match self { match self {
ArtifactsCache::Ephemeral(_, _) => Ok(Default::default()), ArtifactsCache::Ephemeral(_, _) => {
tracing::trace!("no cache configured, ephemeral");
Ok(Default::default())
}
ArtifactsCache::Cached(cache) => { ArtifactsCache::Cached(cache) => {
let ArtifactsCacheInner { let ArtifactsCacheInner {
mut cache, mut cache,

View File

@ -358,13 +358,14 @@ impl<'a, T: ArtifactOutput> ArtifactsState<'a, T> {
/// ///
/// this concludes the [`Project::compile()`] statemachine /// this concludes the [`Project::compile()`] statemachine
fn write_cache(self) -> Result<ProjectCompileOutput<T>> { fn write_cache(self) -> Result<ProjectCompileOutput<T>> {
trace!("write cache");
let ArtifactsState { output, cache, compiled_artifacts } = self; let ArtifactsState { output, cache, compiled_artifacts } = self;
let project = cache.project(); let project = cache.project();
let ignored_error_codes = project.ignored_error_codes.clone(); let ignored_error_codes = project.ignored_error_codes.clone();
let compiler_severity_filter = project.compiler_severity_filter.clone(); let compiler_severity_filter = project.compiler_severity_filter.clone();
let skip_write_to_disk = project.no_artifacts || let has_error = output.has_error(&ignored_error_codes, &compiler_severity_filter);
output.has_error(&ignored_error_codes, &compiler_severity_filter); let skip_write_to_disk = project.no_artifacts || has_error;
trace!(has_error, project.no_artifacts, skip_write_to_disk, cache_path=?project.cache_path(),"prepare writing cache file");
let cached_artifacts = cache.consume(&compiled_artifacts, !skip_write_to_disk)?; let cached_artifacts = cache.consume(&compiled_artifacts, !skip_write_to_disk)?;
Ok(ProjectCompileOutput { Ok(ProjectCompileOutput {
compiler_output: output, compiler_output: output,