From a0d7995f9400829228d64c385d59ab3e59f88bc2 Mon Sep 17 00:00:00 2001
From: Curtis Spencer <41347+jubos@users.noreply.github.com>
Date: Sat, 19 Mar 2022 11:32:19 -0700
Subject: [PATCH] chore(etherscan): Return error for unverified contracts
 (#1065)

Given contract source code is not useful in the case of unverified contracts
have the contract_source_code method return an error in the case if the item.abi
has the "Contract source code not verified" string.

Uncomment unit test ignore and run test:
> cargo test --lib ethers-etherscan -- get_error
---
 ethers-etherscan/src/contract.rs | 26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/ethers-etherscan/src/contract.rs b/ethers-etherscan/src/contract.rs
index a3d11146..29a63ea0 100644
--- a/ethers-etherscan/src/contract.rs
+++ b/ethers-etherscan/src/contract.rs
@@ -310,6 +310,9 @@ impl Client {
         let query =
             self.create_query("contract", "getsourcecode", HashMap::from([("address", address)]));
         let response: Response<Vec<Metadata>> = self.get_json(&query).await?;
+        if response.result.iter().any(|item| item.abi == "Contract source code not verified") {
+            return Err(EtherscanError::ContractCodeNotVerified(address))
+        }
         Ok(ContractMetadata { items: response.result })
     }
 }
@@ -323,7 +326,7 @@ mod tests {
     use ethers_core::types::Chain;
     use ethers_solc::{Project, ProjectPathsConfig};
 
-    use crate::{contract::VerifyContract, tests::run_at_least_duration, Client};
+    use crate::{contract::VerifyContract, tests::run_at_least_duration, Client, EtherscanError};
 
     #[tokio::test]
     #[serial]
@@ -355,6 +358,27 @@ mod tests {
         .await
     }
 
+    #[tokio::test]
+    #[serial]
+    #[ignore]
+    async fn can_get_error_on_unverified_contract() {
+        run_at_least_duration(Duration::from_millis(250), async {
+            let client = Client::new_from_env(Chain::Mainnet).unwrap();
+            let unverified_addr = "0xb5c31a0e22cae98ac08233e512bd627885aa24e5".parse().unwrap();
+            let result = client.contract_source_code(unverified_addr).await;
+            match result.err() {
+                Some(error) => match error {
+                    EtherscanError::ContractCodeNotVerified(addr) => {
+                        assert_eq!(addr, unverified_addr);
+                    }
+                    _ => panic!("Invalid EtherscanError type"),
+                },
+                None => panic!("Result should contain ContractCodeNotVerified error"),
+            }
+        })
+        .await
+    }
+
     /// Query a contract that has a single string source entry instead of underlying JSON metadata.
     #[tokio::test]
     #[serial]