LumeWeb
/
ethers-rs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: parse_units was generating an error on some values because of extra decimal places added round to prevent error (#701)

This commit is contained in:
x3ccd4828 2021-12-17 04:22:37 -05:00 committed by GitHub
parent 4d647453e3
commit 6cecc4824a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ethers-core/src/utils/mod.rs
View File

@ -138,11 +138,11 @@ where
pub fn parse_units<K, S>(amount: S, units: K) -> Result<U256, ConversionError> pub fn parse_units<K, S>(amount: S, units: K) -> Result<U256, ConversionError>
where where
S: ToString, S: ToString,
K: TryInto<Units, Error = ConversionError>, K: TryInto<Units, Error = ConversionError> + Copy,
{ {
let float_n: f64 = let float_n: f64 =
amount.to_string().parse::<f64>()? * 10u64.pow(units.try_into()?.as_num()) as f64; amount.to_string().parse::<f64>()? * 10u64.pow(units.try_into()?.as_num()) as f64;
let u256_n: U256 = U256::from_dec_str(&float_n.to_string())?; let u256_n: U256 = U256::from_dec_str(&float_n.round().to_string())?;
Ok(u256_n) Ok(u256_n)
} }
/// The address for an Ethereum contract is deterministically computed from the /// The address for an Ethereum contract is deterministically computed from the
@ -430,6 +430,9 @@ mod tests {
let gwei = parse_units(1.5, 9).unwrap(); let gwei = parse_units(1.5, 9).unwrap();
assert_eq!(gwei.as_u64(), 15e8 as u64); assert_eq!(gwei.as_u64(), 15e8 as u64);
let token = parse_units(1163.56926418, 8).unwrap();
assert_eq!(token.as_u64(), 116356926418);
let eth_dec_float = parse_units(1.39563324, "ether").unwrap(); let eth_dec_float = parse_units(1.39563324, "ether").unwrap();
assert_eq!(eth_dec_float, U256::from_dec_str("1395633240000000000").unwrap()); assert_eq!(eth_dec_float, U256::from_dec_str("1395633240000000000").unwrap());