From 20f7ac289c620b79731b29e8014d95ef568827c4 Mon Sep 17 00:00:00 2001
From: Devan Non <89424366+devanonon@users.noreply.github.com>
Date: Thu, 21 Apr 2022 19:23:51 +0200
Subject: [PATCH] Cleanup of links and requirements in README (#1163)

* chore: remove broken link and old unused test

* chore: add solc version required and geth requirement for tests
---
 README.md                |  5 +++--
 tests/major_contracts.rs | 37 -------------------------------------
 2 files changed, 3 insertions(+), 39 deletions(-)
 delete mode 100644 tests/major_contracts.rs

diff --git a/README.md b/README.md
index 5309b18e..2d4fdcde 100644
--- a/README.md
+++ b/README.md
@@ -31,11 +31,12 @@ ethers = { git = "https://github.com/gakonst/ethers-rs" }
 
 Tests require the following installed:
 
-1. [`solc`](https://solidity.readthedocs.io/en/latest/installing-solidity.html). We also recommend using [solc-select](https://github.com/crytic/solc-select) for more flexibility.
+1. [`solc`](https://solidity.readthedocs.io/en/latest/installing-solidity.html) (>=0.8.10). We also recommend using [solc-select](https://github.com/crytic/solc-select) for more flexibility.
 2. [`ganache-cli`](https://github.com/trufflesuite/ganache-cli#installation)
+3. [`geth`](https://github.com/ethereum/go-ethereum)
 
 In addition, it is recommended that you set the `ETHERSCAN_API_KEY` environment variable
-for [the abigen via Etherscan](https://github.com/gakonst/ethers-rs/blob/master/ethers/tests/major_contracts.rs) tests.
+for [the abigen via Etherscan](https://github.com/gakonst/ethers-rs/blob/master/ethers-contract/tests/abigen.rs) tests.
 You can get one [here](https://etherscan.io/apis).
 
 ### EVM-compatible chains support
diff --git a/tests/major_contracts.rs b/tests/major_contracts.rs
deleted file mode 100644
index d72a3ad0..00000000
--- a/tests/major_contracts.rs
+++ /dev/null
@@ -1,37 +0,0 @@
-// // This test exists to ensure that the abigen macro works "reasonably" well with popular
-// contracts use ethers::contract::abigen;
-//
-// abigen!(
-//     KeepBonding,
-//     "etherscan:0x7137701e90C6a80B0dA36922cd83942b32A8fc95"
-// );
-// abigen!(cDAI, "etherscan:0x5d3a536E4D6DbD6114cc1Ead35777bAB948E3643");
-// abigen!(
-//     Comptroller,
-//     "etherscan:0x3d9819210a31b4961b30ef54be2aed79b9c9cd3b"
-// );
-//
-// // https://github.com/vyperlang/vyper/issues/1931
-// // abigen!(
-// //     Curve,
-// //     "etherscan:0xa2b47e3d5c44877cca798226b7b8118f9bfb7a56"
-// // );
-// abigen!(
-//     UmaAdmin,
-//     "etherscan:0x4E6CCB1dA3C7844887F9A5aF4e8450d9fd90317A"
-// );
-//
-// // e.g. aave's `initialize` methods exist multiple times, so we should rename it
-// abigen!(
-//     AavePoolCore,
-//     "etherscan:0x3dfd23a6c5e8bbcfc9581d2e864a68feb6a076d3",
-//     methods {
-//         initialize(address,bytes) as initialize_proxy;
-//     }
-// );
-//
-// // The DyDxLimitOrders contract uses Abi Encoder v2 with nested tuples
-// abigen!(
-//     DyDxLimitOrders,
-//     "etherscan:0xDEf136D9884528e1EB302f39457af0E4d3AD24EB"
-// );