2021-08-01 21:18:24 +00:00
|
|
|
//! AWS KMS-based Signer
|
|
|
|
|
|
|
|
use ethers_core::{
|
|
|
|
k256::ecdsa::{Error as K256Error, Signature as KSig, VerifyingKey},
|
derive-eip712: initial implementation of eip712 derive macro (#481)
* derive-eip712: initial implementation of eip712 derive macro
This commit provides an initial implementation for a derive macro
to encode typed data according to EIP-712, https://eips.ethereum.org/EIPS/eip-712
Additionally, this commit introduces a new signer trait method:
async fn sign_typed_data<T: Eip712 + Send + Sync>(
&self,
payload: &T,
) -> Result<Signature, Self::Error>;
And implements the new method for each of the signers (wallet, ledger,
aws).
Additionally, these changes include using `WalletError` for the Wallet
signer error type
At the moment, derive does not recurse the primary type to find nested
Eip712 structs. This is something that is noted in the source and
currently responds with an error regarding custom types.
A subsequent PR should be opened once this issue becomes needed. For the
moment, the current implementation should satisfy non-nested, basic struct types.
* rename to ethers-derive-eip712; move to ethers-core
* refactor of derive-eip712 macro; use ParamType and EthAbiToken
* macro updates; add byte array checker for paramtype; use literal constant for domain type hash
* replace std::convert::Infallible with WalletError as Wallet signer error type
* update workspace members and dev dependencies for examples folder
* add example for eip712 and test against contract
* remove extraneous backward slash in '\x19\x01' prefix; example tests pass
* update unreleased change log
* remove print statements
* use parse_macro_input macro; remove dead code; handle nest struct not implemented error
* move eip712 example to solidity-contract tests folder; update cargo workspace dependencies
* allow optional EIP712Domain parameter when encoding eip712 struct and signing typed data
* add documentation for eip712 feature
* Update ethers-signers/src/ledger/mod.rs
Co-authored-by: Sebastian Martinez <me@sebastinez.dev>
* add error enum for Eip712Error; use sign_payload for ledger signer
* add EIP712WithDomain type for providing a wrapper around custom setting of the domain
* make LedgerWallet sign_payload public
* use optional feature gated dependencies for eip712; add default method for encode_eip712
* add default domain_separator method, pre-compute separator hash
* move derive-eip712 deps to dev deps
* remove invalid sign payload parameter, add await on async method
* remove deprecated comment
* debugging 'bad key handle' error for ledger signer
try using 'sign_message'
* await sign digest for aws signer
* remove extra space, fix fmt warning
* fix test, fmt errors
* use gt 0.6.0 pragma compiler version
* enable ABIEncoderV2 for solidity test contract
* chore: make test constructor public
Co-authored-by: Sebastian Martinez <me@sebastinez.dev>
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
2021-10-08 15:22:51 +00:00
|
|
|
types::{
|
2021-10-29 12:29:35 +00:00
|
|
|
transaction::{eip2718::TypedTransaction, eip712::Eip712},
|
|
|
|
Address, Signature as EthSig, H256,
|
derive-eip712: initial implementation of eip712 derive macro (#481)
* derive-eip712: initial implementation of eip712 derive macro
This commit provides an initial implementation for a derive macro
to encode typed data according to EIP-712, https://eips.ethereum.org/EIPS/eip-712
Additionally, this commit introduces a new signer trait method:
async fn sign_typed_data<T: Eip712 + Send + Sync>(
&self,
payload: &T,
) -> Result<Signature, Self::Error>;
And implements the new method for each of the signers (wallet, ledger,
aws).
Additionally, these changes include using `WalletError` for the Wallet
signer error type
At the moment, derive does not recurse the primary type to find nested
Eip712 structs. This is something that is noted in the source and
currently responds with an error regarding custom types.
A subsequent PR should be opened once this issue becomes needed. For the
moment, the current implementation should satisfy non-nested, basic struct types.
* rename to ethers-derive-eip712; move to ethers-core
* refactor of derive-eip712 macro; use ParamType and EthAbiToken
* macro updates; add byte array checker for paramtype; use literal constant for domain type hash
* replace std::convert::Infallible with WalletError as Wallet signer error type
* update workspace members and dev dependencies for examples folder
* add example for eip712 and test against contract
* remove extraneous backward slash in '\x19\x01' prefix; example tests pass
* update unreleased change log
* remove print statements
* use parse_macro_input macro; remove dead code; handle nest struct not implemented error
* move eip712 example to solidity-contract tests folder; update cargo workspace dependencies
* allow optional EIP712Domain parameter when encoding eip712 struct and signing typed data
* add documentation for eip712 feature
* Update ethers-signers/src/ledger/mod.rs
Co-authored-by: Sebastian Martinez <me@sebastinez.dev>
* add error enum for Eip712Error; use sign_payload for ledger signer
* add EIP712WithDomain type for providing a wrapper around custom setting of the domain
* make LedgerWallet sign_payload public
* use optional feature gated dependencies for eip712; add default method for encode_eip712
* add default domain_separator method, pre-compute separator hash
* move derive-eip712 deps to dev deps
* remove invalid sign payload parameter, add await on async method
* remove deprecated comment
* debugging 'bad key handle' error for ledger signer
try using 'sign_message'
* await sign digest for aws signer
* remove extra space, fix fmt warning
* fix test, fmt errors
* use gt 0.6.0 pragma compiler version
* enable ABIEncoderV2 for solidity test contract
* chore: make test constructor public
Co-authored-by: Sebastian Martinez <me@sebastinez.dev>
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
2021-10-08 15:22:51 +00:00
|
|
|
},
|
2021-08-01 21:18:24 +00:00
|
|
|
utils::hash_message,
|
|
|
|
};
|
|
|
|
use rusoto_core::RusotoError;
|
|
|
|
use rusoto_kms::{
|
|
|
|
GetPublicKeyError, GetPublicKeyRequest, Kms, KmsClient, SignError, SignRequest, SignResponse,
|
|
|
|
};
|
|
|
|
use tracing::{debug, instrument, trace};
|
|
|
|
|
|
|
|
mod utils;
|
|
|
|
use utils::{apply_eip155, rsig_to_ethsig, verifying_key_to_address};
|
|
|
|
|
|
|
|
/// An ethers Signer that uses keys held in Amazon AWS KMS.
|
|
|
|
///
|
|
|
|
/// The AWS Signer passes signing requests to the cloud service. AWS KMS keys
|
|
|
|
/// are identified by a UUID, the `key_id`.
|
|
|
|
///
|
|
|
|
/// Because the public key is unknwon, we retrieve it on instantiation of the
|
|
|
|
/// signer. This means that the new function is `async` and must be called
|
|
|
|
/// within some runtime.
|
|
|
|
///
|
|
|
|
/// ```compile_fail
|
|
|
|
/// use rusoto_core::Client;
|
|
|
|
/// use rusoto_kms::{Kms, KmsClient};
|
|
|
|
///
|
|
|
|
/// user ethers_signers::Signer;
|
|
|
|
///
|
|
|
|
/// let client = Client::new_with(
|
|
|
|
/// EnvironmentProvider::default(),
|
|
|
|
/// HttpClient::new().unwrap()
|
|
|
|
/// );
|
|
|
|
/// let kms_client = KmsClient::new_with_client(client, Region::UsWest1);
|
|
|
|
/// let key_id = "...";
|
|
|
|
/// let chain_id = 1;
|
|
|
|
///
|
|
|
|
/// let signer = AwsSigner::new(kms_client, key_id, chain_id).await?;
|
|
|
|
/// let sig = signer.sign_message(H256::zero()).await?;
|
|
|
|
/// ```
|
|
|
|
#[derive(Clone)]
|
|
|
|
pub struct AwsSigner<'a> {
|
|
|
|
kms: &'a rusoto_kms::KmsClient,
|
|
|
|
chain_id: u64,
|
|
|
|
key_id: String,
|
|
|
|
pubkey: VerifyingKey,
|
|
|
|
address: Address,
|
|
|
|
}
|
|
|
|
|
|
|
|
impl<'a> std::fmt::Debug for AwsSigner<'a> {
|
|
|
|
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
|
|
|
|
f.debug_struct("AwsSigner")
|
|
|
|
.field("key_id", &self.key_id)
|
|
|
|
.field("chain_id", &self.chain_id)
|
|
|
|
.field("pubkey", &hex::encode(self.pubkey.to_bytes()))
|
|
|
|
.field("address", &self.address)
|
|
|
|
.finish()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl<'a> std::fmt::Display for AwsSigner<'a> {
|
|
|
|
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
|
|
|
|
write!(
|
|
|
|
f,
|
|
|
|
"AwsSigner {{ address: {}, chain_id: {}, key_id: {} }}",
|
|
|
|
self.address, self.chain_id, self.key_id
|
|
|
|
)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Errors produced by the AwsSigner
|
|
|
|
#[derive(thiserror::Error, Debug)]
|
|
|
|
pub enum AwsSignerError {
|
|
|
|
#[error("{0}")]
|
|
|
|
SignError(#[from] RusotoError<SignError>),
|
|
|
|
#[error("{0}")]
|
|
|
|
GetPublicKeyError(#[from] RusotoError<GetPublicKeyError>),
|
|
|
|
#[error("{0}")]
|
|
|
|
K256(#[from] K256Error),
|
|
|
|
#[error("{0}")]
|
2021-12-20 22:41:57 +00:00
|
|
|
Spki(spki::Error),
|
2021-08-01 21:18:24 +00:00
|
|
|
#[error("{0}")]
|
|
|
|
Other(String),
|
derive-eip712: initial implementation of eip712 derive macro (#481)
* derive-eip712: initial implementation of eip712 derive macro
This commit provides an initial implementation for a derive macro
to encode typed data according to EIP-712, https://eips.ethereum.org/EIPS/eip-712
Additionally, this commit introduces a new signer trait method:
async fn sign_typed_data<T: Eip712 + Send + Sync>(
&self,
payload: &T,
) -> Result<Signature, Self::Error>;
And implements the new method for each of the signers (wallet, ledger,
aws).
Additionally, these changes include using `WalletError` for the Wallet
signer error type
At the moment, derive does not recurse the primary type to find nested
Eip712 structs. This is something that is noted in the source and
currently responds with an error regarding custom types.
A subsequent PR should be opened once this issue becomes needed. For the
moment, the current implementation should satisfy non-nested, basic struct types.
* rename to ethers-derive-eip712; move to ethers-core
* refactor of derive-eip712 macro; use ParamType and EthAbiToken
* macro updates; add byte array checker for paramtype; use literal constant for domain type hash
* replace std::convert::Infallible with WalletError as Wallet signer error type
* update workspace members and dev dependencies for examples folder
* add example for eip712 and test against contract
* remove extraneous backward slash in '\x19\x01' prefix; example tests pass
* update unreleased change log
* remove print statements
* use parse_macro_input macro; remove dead code; handle nest struct not implemented error
* move eip712 example to solidity-contract tests folder; update cargo workspace dependencies
* allow optional EIP712Domain parameter when encoding eip712 struct and signing typed data
* add documentation for eip712 feature
* Update ethers-signers/src/ledger/mod.rs
Co-authored-by: Sebastian Martinez <me@sebastinez.dev>
* add error enum for Eip712Error; use sign_payload for ledger signer
* add EIP712WithDomain type for providing a wrapper around custom setting of the domain
* make LedgerWallet sign_payload public
* use optional feature gated dependencies for eip712; add default method for encode_eip712
* add default domain_separator method, pre-compute separator hash
* move derive-eip712 deps to dev deps
* remove invalid sign payload parameter, add await on async method
* remove deprecated comment
* debugging 'bad key handle' error for ledger signer
try using 'sign_message'
* await sign digest for aws signer
* remove extra space, fix fmt warning
* fix test, fmt errors
* use gt 0.6.0 pragma compiler version
* enable ABIEncoderV2 for solidity test contract
* chore: make test constructor public
Co-authored-by: Sebastian Martinez <me@sebastinez.dev>
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
2021-10-08 15:22:51 +00:00
|
|
|
#[error(transparent)]
|
|
|
|
/// Error when converting from a hex string
|
|
|
|
HexError(#[from] hex::FromHexError),
|
|
|
|
/// Error type from Eip712Error message
|
|
|
|
#[error("error encoding eip712 struct: {0:?}")]
|
|
|
|
Eip712Error(String),
|
2021-08-01 21:18:24 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
impl From<String> for AwsSignerError {
|
|
|
|
fn from(s: String) -> Self {
|
|
|
|
Self::Other(s)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-12-20 22:41:57 +00:00
|
|
|
impl From<spki::Error> for AwsSignerError {
|
|
|
|
fn from(e: spki::Error) -> Self {
|
2021-08-01 21:18:24 +00:00
|
|
|
Self::Spki(e)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
#[instrument(err, skip(kms, key_id), fields(key_id = %key_id.as_ref()))]
|
|
|
|
async fn request_get_pubkey<T>(
|
|
|
|
kms: &KmsClient,
|
|
|
|
key_id: T,
|
|
|
|
) -> Result<rusoto_kms::GetPublicKeyResponse, RusotoError<GetPublicKeyError>>
|
|
|
|
where
|
|
|
|
T: AsRef<str>,
|
|
|
|
{
|
|
|
|
debug!("Dispatching get_public_key");
|
|
|
|
|
2021-10-29 12:29:35 +00:00
|
|
|
let req = GetPublicKeyRequest { grant_tokens: None, key_id: key_id.as_ref().to_owned() };
|
2021-08-01 21:18:24 +00:00
|
|
|
trace!("{:?}", &req);
|
|
|
|
let resp = kms.get_public_key(req).await;
|
|
|
|
trace!("{:?}", &resp);
|
|
|
|
resp
|
|
|
|
}
|
|
|
|
|
|
|
|
#[instrument(err, skip(kms, digest, key_id), fields(digest = %hex::encode(&digest), key_id = %key_id.as_ref()))]
|
|
|
|
async fn request_sign_digest<T>(
|
|
|
|
kms: &KmsClient,
|
|
|
|
key_id: T,
|
|
|
|
digest: [u8; 32],
|
|
|
|
) -> Result<SignResponse, RusotoError<SignError>>
|
|
|
|
where
|
|
|
|
T: AsRef<str>,
|
|
|
|
{
|
|
|
|
debug!("Dispatching sign");
|
|
|
|
let req = SignRequest {
|
|
|
|
grant_tokens: None,
|
|
|
|
key_id: key_id.as_ref().to_owned(),
|
|
|
|
message: digest.to_vec().into(),
|
|
|
|
message_type: Some("DIGEST".to_owned()),
|
|
|
|
signing_algorithm: "ECDSA_SHA_256".to_owned(),
|
|
|
|
};
|
|
|
|
trace!("{:?}", &req);
|
|
|
|
let resp = kms.sign(req).await;
|
|
|
|
trace!("{:?}", &resp);
|
|
|
|
resp
|
|
|
|
}
|
|
|
|
|
|
|
|
impl<'a> AwsSigner<'a> {
|
|
|
|
/// Instantiate a new signer from an existing `KmsClient` and Key ID.
|
|
|
|
///
|
|
|
|
/// This function retrieves the public key from AWS and calculates the
|
|
|
|
/// Etheruem address. It is therefore `async`.
|
|
|
|
#[instrument(err, skip(kms, key_id, chain_id), fields(key_id = %key_id.as_ref()))]
|
|
|
|
pub async fn new<T>(
|
|
|
|
kms: &'a KmsClient,
|
|
|
|
key_id: T,
|
|
|
|
chain_id: u64,
|
|
|
|
) -> Result<AwsSigner<'a>, AwsSignerError>
|
|
|
|
where
|
|
|
|
T: AsRef<str>,
|
|
|
|
{
|
2021-10-29 12:29:35 +00:00
|
|
|
let pubkey = request_get_pubkey(kms, &key_id).await.map(utils::decode_pubkey)??;
|
2021-08-01 21:18:24 +00:00
|
|
|
let address = verifying_key_to_address(&pubkey);
|
|
|
|
|
|
|
|
debug!(
|
|
|
|
"Instantiated AWS signer with pubkey 0x{} and address 0x{}",
|
|
|
|
hex::encode(&pubkey.to_bytes()),
|
|
|
|
hex::encode(&address)
|
|
|
|
);
|
|
|
|
|
2021-10-29 12:29:35 +00:00
|
|
|
Ok(Self { kms, chain_id, key_id: key_id.as_ref().to_owned(), pubkey, address })
|
2021-08-01 21:18:24 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/// Fetch the pubkey associated with a key id
|
|
|
|
pub async fn get_pubkey_for_key<T>(&self, key_id: T) -> Result<VerifyingKey, AwsSignerError>
|
|
|
|
where
|
|
|
|
T: AsRef<str>,
|
|
|
|
{
|
2022-01-29 19:19:49 +00:00
|
|
|
request_get_pubkey(self.kms, key_id).await.map(utils::decode_pubkey)?
|
2021-08-01 21:18:24 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/// Fetch the pubkey associated with this signer's key ID
|
|
|
|
pub async fn get_pubkey(&self) -> Result<VerifyingKey, AwsSignerError> {
|
|
|
|
self.get_pubkey_for_key(&self.key_id).await
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Sign a digest with the key associated with a key id
|
|
|
|
pub async fn sign_digest_with_key<T>(
|
|
|
|
&self,
|
|
|
|
key_id: T,
|
|
|
|
digest: [u8; 32],
|
|
|
|
) -> Result<KSig, AwsSignerError>
|
|
|
|
where
|
|
|
|
T: AsRef<str>,
|
|
|
|
{
|
2022-01-29 19:19:49 +00:00
|
|
|
request_sign_digest(self.kms, key_id, digest).await.map(utils::decode_signature)?
|
2021-08-01 21:18:24 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/// Sign a digest with this signer's key
|
|
|
|
pub async fn sign_digest(&self, digest: [u8; 32]) -> Result<KSig, AwsSignerError> {
|
|
|
|
self.sign_digest_with_key(self.key_id.clone(), digest).await
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Sign a digest with this signer's key and add the eip155 `v` value
|
2022-05-02 18:51:25 +00:00
|
|
|
/// corresponding to the input chain_id
|
2021-08-01 21:18:24 +00:00
|
|
|
#[instrument(err, skip(digest), fields(digest = %hex::encode(&digest)))]
|
2022-05-02 18:51:25 +00:00
|
|
|
async fn sign_digest_with_eip155(
|
|
|
|
&self,
|
|
|
|
digest: H256,
|
|
|
|
chain_id: u64,
|
|
|
|
) -> Result<EthSig, AwsSignerError> {
|
2021-08-01 21:18:24 +00:00
|
|
|
let sig = self.sign_digest(digest.into()).await?;
|
|
|
|
|
|
|
|
let sig = utils::rsig_from_digest_bytes_trial_recovery(&sig, digest.into(), &self.pubkey);
|
|
|
|
|
|
|
|
let mut sig = rsig_to_ethsig(&sig);
|
2022-05-02 18:51:25 +00:00
|
|
|
apply_eip155(&mut sig, chain_id);
|
2021-08-01 21:18:24 +00:00
|
|
|
Ok(sig)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
#[async_trait::async_trait]
|
|
|
|
impl<'a> super::Signer for AwsSigner<'a> {
|
|
|
|
type Error = AwsSignerError;
|
|
|
|
|
|
|
|
#[instrument(err, skip(message))]
|
|
|
|
async fn sign_message<S: Send + Sync + AsRef<[u8]>>(
|
|
|
|
&self,
|
|
|
|
message: S,
|
|
|
|
) -> Result<EthSig, Self::Error> {
|
|
|
|
let message = message.as_ref();
|
|
|
|
let message_hash = hash_message(message);
|
|
|
|
trace!("{:?}", message_hash);
|
|
|
|
trace!("{:?}", message);
|
|
|
|
|
2022-05-02 18:51:25 +00:00
|
|
|
self.sign_digest_with_eip155(message_hash, self.chain_id).await
|
2021-08-01 21:18:24 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
#[instrument(err)]
|
2021-08-09 00:31:11 +00:00
|
|
|
async fn sign_transaction(&self, tx: &TypedTransaction) -> Result<EthSig, Self::Error> {
|
2022-05-02 18:51:25 +00:00
|
|
|
let mut tx_with_chain = tx.clone();
|
|
|
|
let chain_id = tx_with_chain.chain_id().map(|id| id.as_u64()).unwrap_or(self.chain_id);
|
|
|
|
tx_with_chain.set_chain_id(chain_id);
|
|
|
|
|
2022-01-30 19:21:16 +00:00
|
|
|
let sighash = tx.sighash();
|
2022-05-02 18:51:25 +00:00
|
|
|
self.sign_digest_with_eip155(sighash, chain_id).await
|
2021-08-01 21:18:24 +00:00
|
|
|
}
|
|
|
|
|
derive-eip712: initial implementation of eip712 derive macro (#481)
* derive-eip712: initial implementation of eip712 derive macro
This commit provides an initial implementation for a derive macro
to encode typed data according to EIP-712, https://eips.ethereum.org/EIPS/eip-712
Additionally, this commit introduces a new signer trait method:
async fn sign_typed_data<T: Eip712 + Send + Sync>(
&self,
payload: &T,
) -> Result<Signature, Self::Error>;
And implements the new method for each of the signers (wallet, ledger,
aws).
Additionally, these changes include using `WalletError` for the Wallet
signer error type
At the moment, derive does not recurse the primary type to find nested
Eip712 structs. This is something that is noted in the source and
currently responds with an error regarding custom types.
A subsequent PR should be opened once this issue becomes needed. For the
moment, the current implementation should satisfy non-nested, basic struct types.
* rename to ethers-derive-eip712; move to ethers-core
* refactor of derive-eip712 macro; use ParamType and EthAbiToken
* macro updates; add byte array checker for paramtype; use literal constant for domain type hash
* replace std::convert::Infallible with WalletError as Wallet signer error type
* update workspace members and dev dependencies for examples folder
* add example for eip712 and test against contract
* remove extraneous backward slash in '\x19\x01' prefix; example tests pass
* update unreleased change log
* remove print statements
* use parse_macro_input macro; remove dead code; handle nest struct not implemented error
* move eip712 example to solidity-contract tests folder; update cargo workspace dependencies
* allow optional EIP712Domain parameter when encoding eip712 struct and signing typed data
* add documentation for eip712 feature
* Update ethers-signers/src/ledger/mod.rs
Co-authored-by: Sebastian Martinez <me@sebastinez.dev>
* add error enum for Eip712Error; use sign_payload for ledger signer
* add EIP712WithDomain type for providing a wrapper around custom setting of the domain
* make LedgerWallet sign_payload public
* use optional feature gated dependencies for eip712; add default method for encode_eip712
* add default domain_separator method, pre-compute separator hash
* move derive-eip712 deps to dev deps
* remove invalid sign payload parameter, add await on async method
* remove deprecated comment
* debugging 'bad key handle' error for ledger signer
try using 'sign_message'
* await sign digest for aws signer
* remove extra space, fix fmt warning
* fix test, fmt errors
* use gt 0.6.0 pragma compiler version
* enable ABIEncoderV2 for solidity test contract
* chore: make test constructor public
Co-authored-by: Sebastian Martinez <me@sebastinez.dev>
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
2021-10-08 15:22:51 +00:00
|
|
|
async fn sign_typed_data<T: Eip712 + Send + Sync>(
|
|
|
|
&self,
|
2021-10-19 08:52:36 +00:00
|
|
|
payload: &T,
|
derive-eip712: initial implementation of eip712 derive macro (#481)
* derive-eip712: initial implementation of eip712 derive macro
This commit provides an initial implementation for a derive macro
to encode typed data according to EIP-712, https://eips.ethereum.org/EIPS/eip-712
Additionally, this commit introduces a new signer trait method:
async fn sign_typed_data<T: Eip712 + Send + Sync>(
&self,
payload: &T,
) -> Result<Signature, Self::Error>;
And implements the new method for each of the signers (wallet, ledger,
aws).
Additionally, these changes include using `WalletError` for the Wallet
signer error type
At the moment, derive does not recurse the primary type to find nested
Eip712 structs. This is something that is noted in the source and
currently responds with an error regarding custom types.
A subsequent PR should be opened once this issue becomes needed. For the
moment, the current implementation should satisfy non-nested, basic struct types.
* rename to ethers-derive-eip712; move to ethers-core
* refactor of derive-eip712 macro; use ParamType and EthAbiToken
* macro updates; add byte array checker for paramtype; use literal constant for domain type hash
* replace std::convert::Infallible with WalletError as Wallet signer error type
* update workspace members and dev dependencies for examples folder
* add example for eip712 and test against contract
* remove extraneous backward slash in '\x19\x01' prefix; example tests pass
* update unreleased change log
* remove print statements
* use parse_macro_input macro; remove dead code; handle nest struct not implemented error
* move eip712 example to solidity-contract tests folder; update cargo workspace dependencies
* allow optional EIP712Domain parameter when encoding eip712 struct and signing typed data
* add documentation for eip712 feature
* Update ethers-signers/src/ledger/mod.rs
Co-authored-by: Sebastian Martinez <me@sebastinez.dev>
* add error enum for Eip712Error; use sign_payload for ledger signer
* add EIP712WithDomain type for providing a wrapper around custom setting of the domain
* make LedgerWallet sign_payload public
* use optional feature gated dependencies for eip712; add default method for encode_eip712
* add default domain_separator method, pre-compute separator hash
* move derive-eip712 deps to dev deps
* remove invalid sign payload parameter, add await on async method
* remove deprecated comment
* debugging 'bad key handle' error for ledger signer
try using 'sign_message'
* await sign digest for aws signer
* remove extra space, fix fmt warning
* fix test, fmt errors
* use gt 0.6.0 pragma compiler version
* enable ABIEncoderV2 for solidity test contract
* chore: make test constructor public
Co-authored-by: Sebastian Martinez <me@sebastinez.dev>
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
2021-10-08 15:22:51 +00:00
|
|
|
) -> Result<EthSig, Self::Error> {
|
2022-05-25 21:15:00 +00:00
|
|
|
let digest =
|
|
|
|
payload.encode_eip712().map_err(|e| Self::Error::Eip712Error(e.to_string()))?;
|
derive-eip712: initial implementation of eip712 derive macro (#481)
* derive-eip712: initial implementation of eip712 derive macro
This commit provides an initial implementation for a derive macro
to encode typed data according to EIP-712, https://eips.ethereum.org/EIPS/eip-712
Additionally, this commit introduces a new signer trait method:
async fn sign_typed_data<T: Eip712 + Send + Sync>(
&self,
payload: &T,
) -> Result<Signature, Self::Error>;
And implements the new method for each of the signers (wallet, ledger,
aws).
Additionally, these changes include using `WalletError` for the Wallet
signer error type
At the moment, derive does not recurse the primary type to find nested
Eip712 structs. This is something that is noted in the source and
currently responds with an error regarding custom types.
A subsequent PR should be opened once this issue becomes needed. For the
moment, the current implementation should satisfy non-nested, basic struct types.
* rename to ethers-derive-eip712; move to ethers-core
* refactor of derive-eip712 macro; use ParamType and EthAbiToken
* macro updates; add byte array checker for paramtype; use literal constant for domain type hash
* replace std::convert::Infallible with WalletError as Wallet signer error type
* update workspace members and dev dependencies for examples folder
* add example for eip712 and test against contract
* remove extraneous backward slash in '\x19\x01' prefix; example tests pass
* update unreleased change log
* remove print statements
* use parse_macro_input macro; remove dead code; handle nest struct not implemented error
* move eip712 example to solidity-contract tests folder; update cargo workspace dependencies
* allow optional EIP712Domain parameter when encoding eip712 struct and signing typed data
* add documentation for eip712 feature
* Update ethers-signers/src/ledger/mod.rs
Co-authored-by: Sebastian Martinez <me@sebastinez.dev>
* add error enum for Eip712Error; use sign_payload for ledger signer
* add EIP712WithDomain type for providing a wrapper around custom setting of the domain
* make LedgerWallet sign_payload public
* use optional feature gated dependencies for eip712; add default method for encode_eip712
* add default domain_separator method, pre-compute separator hash
* move derive-eip712 deps to dev deps
* remove invalid sign payload parameter, add await on async method
* remove deprecated comment
* debugging 'bad key handle' error for ledger signer
try using 'sign_message'
* await sign digest for aws signer
* remove extra space, fix fmt warning
* fix test, fmt errors
* use gt 0.6.0 pragma compiler version
* enable ABIEncoderV2 for solidity test contract
* chore: make test constructor public
Co-authored-by: Sebastian Martinez <me@sebastinez.dev>
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
2021-10-08 15:22:51 +00:00
|
|
|
|
2022-05-25 21:15:00 +00:00
|
|
|
let sig = self.sign_digest(digest).await?;
|
|
|
|
let sig = utils::rsig_from_digest_bytes_trial_recovery(&sig, digest, &self.pubkey);
|
|
|
|
let sig = rsig_to_ethsig(&sig);
|
derive-eip712: initial implementation of eip712 derive macro (#481)
* derive-eip712: initial implementation of eip712 derive macro
This commit provides an initial implementation for a derive macro
to encode typed data according to EIP-712, https://eips.ethereum.org/EIPS/eip-712
Additionally, this commit introduces a new signer trait method:
async fn sign_typed_data<T: Eip712 + Send + Sync>(
&self,
payload: &T,
) -> Result<Signature, Self::Error>;
And implements the new method for each of the signers (wallet, ledger,
aws).
Additionally, these changes include using `WalletError` for the Wallet
signer error type
At the moment, derive does not recurse the primary type to find nested
Eip712 structs. This is something that is noted in the source and
currently responds with an error regarding custom types.
A subsequent PR should be opened once this issue becomes needed. For the
moment, the current implementation should satisfy non-nested, basic struct types.
* rename to ethers-derive-eip712; move to ethers-core
* refactor of derive-eip712 macro; use ParamType and EthAbiToken
* macro updates; add byte array checker for paramtype; use literal constant for domain type hash
* replace std::convert::Infallible with WalletError as Wallet signer error type
* update workspace members and dev dependencies for examples folder
* add example for eip712 and test against contract
* remove extraneous backward slash in '\x19\x01' prefix; example tests pass
* update unreleased change log
* remove print statements
* use parse_macro_input macro; remove dead code; handle nest struct not implemented error
* move eip712 example to solidity-contract tests folder; update cargo workspace dependencies
* allow optional EIP712Domain parameter when encoding eip712 struct and signing typed data
* add documentation for eip712 feature
* Update ethers-signers/src/ledger/mod.rs
Co-authored-by: Sebastian Martinez <me@sebastinez.dev>
* add error enum for Eip712Error; use sign_payload for ledger signer
* add EIP712WithDomain type for providing a wrapper around custom setting of the domain
* make LedgerWallet sign_payload public
* use optional feature gated dependencies for eip712; add default method for encode_eip712
* add default domain_separator method, pre-compute separator hash
* move derive-eip712 deps to dev deps
* remove invalid sign payload parameter, add await on async method
* remove deprecated comment
* debugging 'bad key handle' error for ledger signer
try using 'sign_message'
* await sign digest for aws signer
* remove extra space, fix fmt warning
* fix test, fmt errors
* use gt 0.6.0 pragma compiler version
* enable ABIEncoderV2 for solidity test contract
* chore: make test constructor public
Co-authored-by: Sebastian Martinez <me@sebastinez.dev>
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
2021-10-08 15:22:51 +00:00
|
|
|
|
2022-05-25 21:15:00 +00:00
|
|
|
Ok(sig)
|
derive-eip712: initial implementation of eip712 derive macro (#481)
* derive-eip712: initial implementation of eip712 derive macro
This commit provides an initial implementation for a derive macro
to encode typed data according to EIP-712, https://eips.ethereum.org/EIPS/eip-712
Additionally, this commit introduces a new signer trait method:
async fn sign_typed_data<T: Eip712 + Send + Sync>(
&self,
payload: &T,
) -> Result<Signature, Self::Error>;
And implements the new method for each of the signers (wallet, ledger,
aws).
Additionally, these changes include using `WalletError` for the Wallet
signer error type
At the moment, derive does not recurse the primary type to find nested
Eip712 structs. This is something that is noted in the source and
currently responds with an error regarding custom types.
A subsequent PR should be opened once this issue becomes needed. For the
moment, the current implementation should satisfy non-nested, basic struct types.
* rename to ethers-derive-eip712; move to ethers-core
* refactor of derive-eip712 macro; use ParamType and EthAbiToken
* macro updates; add byte array checker for paramtype; use literal constant for domain type hash
* replace std::convert::Infallible with WalletError as Wallet signer error type
* update workspace members and dev dependencies for examples folder
* add example for eip712 and test against contract
* remove extraneous backward slash in '\x19\x01' prefix; example tests pass
* update unreleased change log
* remove print statements
* use parse_macro_input macro; remove dead code; handle nest struct not implemented error
* move eip712 example to solidity-contract tests folder; update cargo workspace dependencies
* allow optional EIP712Domain parameter when encoding eip712 struct and signing typed data
* add documentation for eip712 feature
* Update ethers-signers/src/ledger/mod.rs
Co-authored-by: Sebastian Martinez <me@sebastinez.dev>
* add error enum for Eip712Error; use sign_payload for ledger signer
* add EIP712WithDomain type for providing a wrapper around custom setting of the domain
* make LedgerWallet sign_payload public
* use optional feature gated dependencies for eip712; add default method for encode_eip712
* add default domain_separator method, pre-compute separator hash
* move derive-eip712 deps to dev deps
* remove invalid sign payload parameter, add await on async method
* remove deprecated comment
* debugging 'bad key handle' error for ledger signer
try using 'sign_message'
* await sign digest for aws signer
* remove extra space, fix fmt warning
* fix test, fmt errors
* use gt 0.6.0 pragma compiler version
* enable ABIEncoderV2 for solidity test contract
* chore: make test constructor public
Co-authored-by: Sebastian Martinez <me@sebastinez.dev>
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
2021-10-08 15:22:51 +00:00
|
|
|
}
|
|
|
|
|
2021-08-01 21:18:24 +00:00
|
|
|
fn address(&self) -> Address {
|
|
|
|
self.address
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Returns the signer's chain id
|
|
|
|
fn chain_id(&self) -> u64 {
|
|
|
|
self.chain_id
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Sets the signer's chain id
|
|
|
|
fn with_chain_id<T: Into<u64>>(mut self, chain_id: T) -> Self {
|
|
|
|
self.chain_id = chain_id.into();
|
|
|
|
self
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
#[cfg(test)]
|
|
|
|
mod tests {
|
|
|
|
use rusoto_core::{
|
|
|
|
credential::{EnvironmentProvider, StaticProvider},
|
|
|
|
Client, HttpClient, Region,
|
|
|
|
};
|
|
|
|
use tracing::metadata::LevelFilter;
|
|
|
|
|
|
|
|
use super::*;
|
|
|
|
use crate::Signer;
|
|
|
|
|
|
|
|
#[allow(dead_code)]
|
|
|
|
fn setup_tracing() {
|
2021-10-29 12:29:35 +00:00
|
|
|
tracing_subscriber::fmt().with_max_level(LevelFilter::DEBUG).try_init().unwrap();
|
2021-08-01 21:18:24 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
#[allow(dead_code)]
|
|
|
|
fn static_client() -> KmsClient {
|
|
|
|
let access_key = "".to_owned();
|
|
|
|
let secret_access_key = "".to_owned();
|
|
|
|
|
|
|
|
let client = Client::new_with(
|
|
|
|
StaticProvider::new(access_key, secret_access_key, None, None),
|
|
|
|
HttpClient::new().unwrap(),
|
|
|
|
);
|
|
|
|
KmsClient::new_with_client(client, Region::UsWest1)
|
|
|
|
}
|
|
|
|
|
|
|
|
#[allow(dead_code)]
|
|
|
|
fn env_client() -> KmsClient {
|
|
|
|
let client = Client::new_with(EnvironmentProvider::default(), HttpClient::new().unwrap());
|
|
|
|
KmsClient::new_with_client(client, Region::UsWest1)
|
|
|
|
}
|
|
|
|
|
|
|
|
#[tokio::test]
|
|
|
|
async fn it_signs_messages() {
|
|
|
|
let chain_id = 1;
|
2021-08-17 12:42:08 +00:00
|
|
|
let key_id = match std::env::var("AWS_KEY_ID") {
|
|
|
|
Ok(id) => id,
|
|
|
|
_ => return,
|
|
|
|
};
|
2021-08-01 21:18:24 +00:00
|
|
|
setup_tracing();
|
|
|
|
let client = env_client();
|
|
|
|
let signer = AwsSigner::new(&client, key_id, chain_id).await.unwrap();
|
|
|
|
|
|
|
|
let message = vec![0, 1, 2, 3];
|
|
|
|
|
|
|
|
let sig = signer.sign_message(&message).await.unwrap();
|
|
|
|
sig.verify(message, signer.address).expect("valid sig");
|
|
|
|
}
|
|
|
|
}
|