LumeWeb
/
chainsafe-bls
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bls-eth-wasm package update for invalidating signature not in g2, validation on by default

This commit is contained in:
g11tech 2021-09-22 11:05:53 +05:30
parent bb1449d878
commit 6854661b29
6 changed files with 29 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.eslintrc.js
View File

@ -44,7 +44,8 @@ module.exports = {
"@typescript-eslint/no-explicit-any": "error", "@typescript-eslint/no-explicit-any": "error",
"@typescript-eslint/no-require-imports": "error", "@typescript-eslint/no-require-imports": "error",
"@typescript-eslint/no-unused-vars": ["error", { "@typescript-eslint/no-unused-vars": ["error", {
"varsIgnorePattern": "^_" "varsIgnorePattern": "^_",
"argsIgnorePattern": "^_",
}], }],
"@typescript-eslint/ban-ts-ignore": "warn", "@typescript-eslint/ban-ts-ignore": "warn",
"@typescript-eslint/no-use-before-define": "off", "@typescript-eslint/no-use-before-define": "off",

2
package.json
View File

@ -40,7 +40,7 @@
}, },
"dependencies": { "dependencies": {
"@chainsafe/bls-keygen": "^0.3.0", "@chainsafe/bls-keygen": "^0.3.0",
"bls-eth-wasm": "^0.4.4", "bls-eth-wasm": "^0.4.8",
"randombytes": "^2.1.0" "randombytes": "^2.1.0"
}, },
"devDependencies": { "devDependencies": {

2
src/blst/signature.ts
View File

@ -10,7 +10,7 @@ export class Signature extends blst.Signature implements ISignature {
} }
/** @param type Defaults to `CoordType.affine` */ /** @param type Defaults to `CoordType.affine` */
static fromBytes(bytes: Uint8Array, type?: blst.CoordType, validate?: boolean): Signature { static fromBytes(bytes: Uint8Array, type?: blst.CoordType, validate = true): Signature {
const sig = blst.Signature.fromBytes(bytes, type); const sig = blst.Signature.fromBytes(bytes, type);
if (validate) sig.sigValidate(); if (validate) sig.sigValidate();
return new Signature(sig.value); return new Signature(sig.value);

5
src/herumi/signature.ts
View File

@ -2,7 +2,7 @@ import {SignatureType, multiVerify} from "bls-eth-wasm";
import {getContext} from "./context"; import {getContext} from "./context";
import {PublicKey} from "./publicKey"; import {PublicKey} from "./publicKey";
import {bytesToHex, concatUint8Arrays, hexToBytes, isZeroUint8Array} from "../helpers"; import {bytesToHex, concatUint8Arrays, hexToBytes, isZeroUint8Array} from "../helpers";
import {PointFormat, Signature as ISignature} from "../interface"; import {PointFormat, Signature as ISignature, CoordType} from "../interface";
import {EmptyAggregateError, InvalidLengthError, InvalidOrderError} from "../errors"; import {EmptyAggregateError, InvalidLengthError, InvalidOrderError} from "../errors";
import {SIGNATURE_LENGTH_COMPRESSED, SIGNATURE_LENGTH_UNCOMPRESSED} from "../constants"; import {SIGNATURE_LENGTH_COMPRESSED, SIGNATURE_LENGTH_UNCOMPRESSED} from "../constants";
@ -17,7 +17,8 @@ export class Signature implements ISignature {
this.value = value; this.value = value;
} }
static fromBytes(bytes: Uint8Array): Signature { static fromBytes(bytes: Uint8Array, _type?: CoordType, validate = true): Signature {
if (validate === false) throw new Error("ValidationSkipNotSupported");
const context = getContext(); const context = getContext();
const signature = new context.Signature(); const signature = new context.Signature();
if (!isZeroUint8Array(bytes)) { if (!isZeroUint8Array(bytes)) {

17
test/unit/index.test.ts
View File

@ -14,6 +14,23 @@ export function runIndexTests(bls: IBls): void {
return {sk, pk, msg, sig}; return {sk, pk, msg, sig};
} }
describe("signature", () => {
it("should fail loading an invalid signature point (not in G2)", () => {
/* eslint-disable max-len */
const POINT_NOT_IN_G2 = Buffer.from(
"8123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef",
"hex"
);
let sig;
try {
sig = bls.Signature.fromBytes(POINT_NOT_IN_G2, undefined, true);
} catch {
/* eslint-disable no-empty */
}
expect(sig === undefined).to.be.true;
});
});
describe("verify", () => { describe("verify", () => {
it("should verify signature", () => { it("should verify signature", () => {
const {pk, msg, sig} = getRandomData(); const {pk, msg, sig} = getRandomData();

10
yarn.lock
View File

@ -158,7 +158,7 @@
integrity sha512-WrKcQiFD1GG04OBnWeeb51Gr0ETx9v4n13S+GI24HQx+NeG1A0LfS44zeu3Tp4PGLbU2cziZudlC0WjF3y/HLQ== integrity sha512-WrKcQiFD1GG04OBnWeeb51Gr0ETx9v4n13S+GI24HQx+NeG1A0LfS44zeu3Tp4PGLbU2cziZudlC0WjF3y/HLQ==
dependencies: dependencies:
"@chainsafe/bls-keygen" "^0.3.0" "@chainsafe/bls-keygen" "^0.3.0"
bls-eth-wasm "^0.4.4" bls-eth-wasm "^0.4.8"
randombytes "^2.1.0" randombytes "^2.1.0"
"@chainsafe/blst@^0.2.0": "@chainsafe/blst@^0.2.0":
@ -933,10 +933,10 @@ blob@0.0.5:
resolved "https://registry.yarnpkg.com/blob/-/blob-0.0.5.tgz#d680eeef25f8cd91ad533f5b01eed48e64caf683" resolved "https://registry.yarnpkg.com/blob/-/blob-0.0.5.tgz#d680eeef25f8cd91ad533f5b01eed48e64caf683"
integrity sha512-gaqbzQPqOoamawKg0LGVd7SzLgXS+JH61oWprSLH+P+abTczqJbhTR8CmJ2u9/bUYNmHTGJx/UEmn6doAvvuig== integrity sha512-gaqbzQPqOoamawKg0LGVd7SzLgXS+JH61oWprSLH+P+abTczqJbhTR8CmJ2u9/bUYNmHTGJx/UEmn6doAvvuig==
bls-eth-wasm@^0.4.4: bls-eth-wasm@^0.4.8:
version "0.4.4" version "0.4.8"
resolved "https://registry.yarnpkg.com/bls-eth-wasm/-/bls-eth-wasm-0.4.4.tgz#3d4c99f8ddee6df23e188dc756125268a0f4d525" resolved "https://registry.yarnpkg.com/bls-eth-wasm/-/bls-eth-wasm-0.4.8.tgz#ad1818fbd1bfb64d8f3e6cd104bd28b96ebaa5f1"
integrity sha512-S6XwscKuxxYTANHZX8tZQxZKvj9IhG3aOCEuy1EnNdsAOfuH2pdRIgWrORwpKd4SLdvmPWap9I+TbJRnFx1Yng== integrity sha512-ye7+G6KFLb3i9xSrLASAoYqOUK5WLB6XA5DD8Sh0UQpZ3T999ylsYbFdoOJpmvTDuBuMi23Vy8Jm0pn/GF01CA==
bluebird@^3.3.0, bluebird@^3.5.5: bluebird@^3.3.0, bluebird@^3.5.5:
version "3.7.2" version "3.7.2"