From 784aa0e2517cdab7c5886027fcc1a7675c19adb2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juan=20Hern=C3=A1ndez=20Serrano?= <j.hernandez@upc.edu>
Date: Tue, 11 Apr 2023 13:31:59 +0200
Subject: [PATCH] only node > 14 supported

---
 .github/workflows/build-and-test.yml    |  4 +--
 .github/workflows/manualpublication.yml | 40 -------------------------
 build/bin/mocha-ts.cjs                  |  6 ++--
 package.json                            |  2 +-
 4 files changed, 7 insertions(+), 45 deletions(-)
 delete mode 100644 .github/workflows/manualpublication.yml

diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml
index f261153..2df5d33 100644
--- a/.github/workflows/build-and-test.yml
+++ b/.github/workflows/build-and-test.yml
@@ -33,7 +33,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
-        node-version: [10.x, 12.x, 14.x, 16.x, 18.x]
+        node-version: [14.x, 16.x, 18.x]
       # When set to true, GitHub cancels all in-progress jobs if any matrix job fails.
       fail-fast: false
       # The maximum number of jobs that can run simultaneously. Set to 1 if you can't run tests in parallel
@@ -49,7 +49,7 @@ jobs:
           registry-url: "https://registry.npmjs.org"
 
       - name: install
-        run: npm ci
+        run: npm i
 
       - name: node esm tests
         run: npm run test:node-esm
diff --git a/.github/workflows/manualpublication.yml b/.github/workflows/manualpublication.yml
deleted file mode 100644
index 1b9bb5e..0000000
--- a/.github/workflows/manualpublication.yml
+++ /dev/null
@@ -1,40 +0,0 @@
-# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
-# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
-
-name: publish
-
-on:
-  workflow_dispatch:
-
-jobs:
-  publication:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2
-      
-      - uses: actions/setup-node@v1
-        with:
-          node-version: 18
-          registry-url: https://registry.npmjs.org/
-      
-      - name: install
-        run: npm ci
-      
-      - name: build
-        run: npm run build
-      
-      - name: browser tests
-        run: npm run test:browser-headless
-      
-      - name: node tests and coverage
-        run: npm run coverage
-      
-      - name: send report to coveralls.io
-        uses: coverallsapp/github-action@master
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-
-      - name: publish to NPM
-        run: npm publish
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
\ No newline at end of file
diff --git a/build/bin/mocha-ts.cjs b/build/bin/mocha-ts.cjs
index 2a96f20..14349a7 100644
--- a/build/bin/mocha-ts.cjs
+++ b/build/bin/mocha-ts.cjs
@@ -58,9 +58,11 @@ function parse () {
     process.exit(1)
   }
 
-  let testsGlob = (args.pop() ?? '').replace(/^['"]/, '').replace(/['"]$/, '') // Let us remove surrounding quotes in string (it gives issues in windows)
-  if (testsGlob === '') {
+  let testsGlob = args.pop()
+  if (testsGlob === undefined) {
     testsGlob = '{src/ts/**/*.spec.ts,test/**/*.ts}'
+  } else {
+    testsGlob = testsGlob.replace(/^['"]/, '').replace(/['"]$/, '') // Let us remove surrounding quotes in string (it gives issues in windows)
   }
 
   const mochaArgs = []
diff --git a/package.json b/package.json
index 8a2b145..9bd572d 100644
--- a/package.json
+++ b/package.json
@@ -22,7 +22,7 @@
   },
   "repository": "github:juanelas/bigint-crypto-utils",
   "engines": {
-    "node": ">=10.4.0"
+    "node": ">=14.0.0"
   },
   "type": "module",
   "main": "./dist/cjs/index.node.cjs",