228 lines
7.0 KiB
JavaScript
228 lines
7.0 KiB
JavaScript
|
/**
|
||
|
* @fileoverview Prevent common casing typos
|
||
|
*/
|
||
|
|
||
|
'use strict';
|
||
|
|
||
|
const PROP_TYPES = Object.keys(require('prop-types'));
|
||
|
const Components = require('../util/Components');
|
||
|
const docsUrl = require('../util/docsUrl');
|
||
|
|
||
|
// ------------------------------------------------------------------------------
|
||
|
// Rule Definition
|
||
|
// ------------------------------------------------------------------------------
|
||
|
|
||
|
const STATIC_CLASS_PROPERTIES = ['propTypes', 'contextTypes', 'childContextTypes', 'defaultProps'];
|
||
|
const LIFECYCLE_METHODS = [
|
||
|
'getDerivedStateFromProps',
|
||
|
'componentWillMount',
|
||
|
'UNSAFE_componentWillMount',
|
||
|
'componentDidMount',
|
||
|
'componentWillReceiveProps',
|
||
|
'UNSAFE_componentWillReceiveProps',
|
||
|
'shouldComponentUpdate',
|
||
|
'componentWillUpdate',
|
||
|
'UNSAFE_componentWillUpdate',
|
||
|
'getSnapshotBeforeUpdate',
|
||
|
'componentDidUpdate',
|
||
|
'componentDidCatch',
|
||
|
'componentWillUnmount',
|
||
|
'render'
|
||
|
];
|
||
|
|
||
|
module.exports = {
|
||
|
meta: {
|
||
|
docs: {
|
||
|
description: 'Prevent common typos',
|
||
|
category: 'Stylistic Issues',
|
||
|
recommended: false,
|
||
|
url: docsUrl('no-typos')
|
||
|
},
|
||
|
schema: []
|
||
|
},
|
||
|
|
||
|
create: Components.detect((context, components, utils) => {
|
||
|
let propTypesPackageName = null;
|
||
|
let reactPackageName = null;
|
||
|
|
||
|
function checkValidPropTypeQualifier(node) {
|
||
|
if (node.name !== 'isRequired') {
|
||
|
context.report({
|
||
|
node,
|
||
|
message: `Typo in prop type chain qualifier: ${node.name}`
|
||
|
});
|
||
|
}
|
||
|
}
|
||
|
|
||
|
function checkValidPropType(node) {
|
||
|
if (node.name && !PROP_TYPES.some(propTypeName => propTypeName === node.name)) {
|
||
|
context.report({
|
||
|
node,
|
||
|
message: `Typo in declared prop type: ${node.name}`
|
||
|
});
|
||
|
}
|
||
|
}
|
||
|
|
||
|
function isPropTypesPackage(node) {
|
||
|
return (
|
||
|
node.type === 'Identifier' &&
|
||
|
node.name === propTypesPackageName
|
||
|
) || (
|
||
|
node.type === 'MemberExpression' &&
|
||
|
node.property.name === 'PropTypes' &&
|
||
|
node.object.name === reactPackageName
|
||
|
);
|
||
|
}
|
||
|
|
||
|
/* eslint-disable no-use-before-define */
|
||
|
|
||
|
function checkValidCallExpression(node) {
|
||
|
const callee = node.callee;
|
||
|
if (callee.type === 'MemberExpression' && callee.property.name === 'shape') {
|
||
|
checkValidPropObject(node.arguments[0]);
|
||
|
} else if (callee.type === 'MemberExpression' && callee.property.name === 'oneOfType') {
|
||
|
const args = node.arguments[0];
|
||
|
if (args && args.type === 'ArrayExpression') {
|
||
|
args.elements.forEach((el) => {
|
||
|
checkValidProp(el);
|
||
|
});
|
||
|
}
|
||
|
}
|
||
|
}
|
||
|
|
||
|
function checkValidProp(node) {
|
||
|
if ((!propTypesPackageName && !reactPackageName) || !node) {
|
||
|
return;
|
||
|
}
|
||
|
|
||
|
if (node.type === 'MemberExpression') {
|
||
|
if (
|
||
|
node.object.type === 'MemberExpression' &&
|
||
|
isPropTypesPackage(node.object.object)
|
||
|
) { // PropTypes.myProp.isRequired
|
||
|
checkValidPropType(node.object.property);
|
||
|
checkValidPropTypeQualifier(node.property);
|
||
|
} else if (
|
||
|
isPropTypesPackage(node.object) &&
|
||
|
node.property.name !== 'isRequired'
|
||
|
) { // PropTypes.myProp
|
||
|
checkValidPropType(node.property);
|
||
|
} else if (node.object.type === 'CallExpression') {
|
||
|
checkValidPropTypeQualifier(node.property);
|
||
|
checkValidCallExpression(node.object);
|
||
|
}
|
||
|
} else if (node.type === 'CallExpression') {
|
||
|
checkValidCallExpression(node);
|
||
|
}
|
||
|
}
|
||
|
|
||
|
/* eslint-enable no-use-before-define */
|
||
|
|
||
|
function checkValidPropObject(node) {
|
||
|
if (node && node.type === 'ObjectExpression') {
|
||
|
node.properties.forEach(prop => checkValidProp(prop.value));
|
||
|
}
|
||
|
}
|
||
|
|
||
|
function reportErrorIfPropertyCasingTypo(node, propertyName, isClassProperty) {
|
||
|
if (propertyName === 'propTypes' || propertyName === 'contextTypes' || propertyName === 'childContextTypes') {
|
||
|
checkValidPropObject(node);
|
||
|
}
|
||
|
STATIC_CLASS_PROPERTIES.forEach((CLASS_PROP) => {
|
||
|
if (propertyName && CLASS_PROP.toLowerCase() === propertyName.toLowerCase() && CLASS_PROP !== propertyName) {
|
||
|
const message = isClassProperty ?
|
||
|
'Typo in static class property declaration' :
|
||
|
'Typo in property declaration';
|
||
|
context.report({
|
||
|
node,
|
||
|
message
|
||
|
});
|
||
|
}
|
||
|
});
|
||
|
}
|
||
|
|
||
|
function reportErrorIfLifecycleMethodCasingTypo(node) {
|
||
|
LIFECYCLE_METHODS.forEach((method) => {
|
||
|
if (method.toLowerCase() === node.key.name.toLowerCase() && method !== node.key.name) {
|
||
|
context.report({
|
||
|
node,
|
||
|
message: 'Typo in component lifecycle method declaration'
|
||
|
});
|
||
|
}
|
||
|
});
|
||
|
}
|
||
|
|
||
|
return {
|
||
|
ImportDeclaration(node) {
|
||
|
if (node.source && node.source.value === 'prop-types') { // import PropType from "prop-types"
|
||
|
propTypesPackageName = node.specifiers[0].local.name;
|
||
|
} else if (node.source && node.source.value === 'react') { // import { PropTypes } from "react"
|
||
|
if (node.specifiers.length > 0) {
|
||
|
reactPackageName = node.specifiers[0].local.name; // guard against accidental anonymous `import "react"`
|
||
|
}
|
||
|
if (node.specifiers.length >= 1) {
|
||
|
const propTypesSpecifier = node.specifiers.find(specifier => (
|
||
|
specifier.imported && specifier.imported.name === 'PropTypes'
|
||
|
));
|
||
|
if (propTypesSpecifier) {
|
||
|
propTypesPackageName = propTypesSpecifier.local.name;
|
||
|
}
|
||
|
}
|
||
|
}
|
||
|
},
|
||
|
|
||
|
ClassProperty(node) {
|
||
|
if (!node.static || !utils.isES6Component(node.parent.parent)) {
|
||
|
return;
|
||
|
}
|
||
|
|
||
|
const tokens = context.getFirstTokens(node, 2);
|
||
|
const propertyName = tokens[1].value;
|
||
|
reportErrorIfPropertyCasingTypo(node.value, propertyName, true);
|
||
|
},
|
||
|
|
||
|
MemberExpression(node) {
|
||
|
const propertyName = node.property.name;
|
||
|
|
||
|
if (
|
||
|
!propertyName ||
|
||
|
STATIC_CLASS_PROPERTIES.map(prop => prop.toLocaleLowerCase()).indexOf(propertyName.toLowerCase()) === -1
|
||
|
) {
|
||
|
return;
|
||
|
}
|
||
|
|
||
|
const relatedComponent = utils.getRelatedComponent(node);
|
||
|
|
||
|
if (
|
||
|
relatedComponent &&
|
||
|
(utils.isES6Component(relatedComponent.node) || utils.isReturningJSX(relatedComponent.node)) &&
|
||
|
(node.parent && node.parent.type === 'AssignmentExpression' && node.parent.right)
|
||
|
) {
|
||
|
reportErrorIfPropertyCasingTypo(node.parent.right, propertyName, true);
|
||
|
}
|
||
|
},
|
||
|
|
||
|
MethodDefinition(node) {
|
||
|
if (!utils.isES6Component(node.parent.parent)) {
|
||
|
return;
|
||
|
}
|
||
|
|
||
|
reportErrorIfLifecycleMethodCasingTypo(node);
|
||
|
},
|
||
|
|
||
|
ObjectExpression(node) {
|
||
|
const component = utils.isES5Component(node) && components.get(node);
|
||
|
|
||
|
if (!component) {
|
||
|
return;
|
||
|
}
|
||
|
|
||
|
node.properties.forEach((property) => {
|
||
|
reportErrorIfPropertyCasingTypo(property.value, property.key.name, false);
|
||
|
reportErrorIfLifecycleMethodCasingTypo(property);
|
||
|
});
|
||
|
}
|
||
|
};
|
||
|
})
|
||
|
};
|